Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent

Pankaj Dev [off-list ref] writes:

1. clk_set_rate : Set new rate to value. Reading returns the
current rate

If you can use this to set *and* read it, then "_set_" shouldn't be in
the name.

What is wrong with using the existing "clk_rate" for reading/setting the
rate?

Hey

The prime motive for clk_set_rate is to set new rate for a clock, since the 'clk_rate' currently available, allows only reading.
To provide reading rate from 'clk_set_rate' is just additional feature.

Regards
Pankaj

-----Original Message-----
From: Holger Schurig [mailto:holgerschurig at gmail.com]
Sent: Friday, February 26, 2016 12:54 PM
To: Pankaj DEV
Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
devicetree at vger.kernel.org; mturquette at linaro.org; kernel at stlinux.com;
sboyd at codeaurora.org; Laurent MEUNIER; lee.jones at linaro.org; Maxime
COQUELIN
Subject: Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-
parent

Pankaj Dev [off-list ref] writes:

quoted

1. clk_set_rate : Set new rate to value. Reading returns the current
rate

If you can use this to set *and* read it, then "_set_" shouldn't be in the name.

What is wrong with using the existing "clk_rate" for reading/setting the rate?