[PATCH RESEND] ASoC: pxa: remove unused variable

Subsystems: pxa2xx/pxa3xx support, sound, sound - soc layer / dynamic audio power management (asoc), the rest

STALE3809d

3 messages, 2 authors, 2016-02-26 · open the first message on its own page

[PATCH RESEND] ASoC: pxa: remove unused variable

From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-02-25 22:03:00

As pointed out by Zhangfei Gao, the sspa_div variable in
brownstone_wm8994_hw_params() is completely unused, so as a cleanup
following a prior patch, this removes both the variable and the division.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Submitted originally on Nov 23 2015, this apparently got lost,
resending it now.

 sound/soc/pxa/brownstone.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/sound/soc/pxa/brownstone.c b/sound/soc/pxa/brownstone.c
index 416ea646c3b1..ec522e94b0e2 100644
--- a/sound/soc/pxa/brownstone.c
+++ b/sound/soc/pxa/brownstone.c
@@ -52,7 +52,6 @@ static int brownstone_wm8994_hw_params(struct snd_pcm_substream *substream,
 	struct snd_soc_dai *codec_dai = rtd->codec_dai;
 	struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
 	int freq_out, sspa_mclk, sysclk;
-	int sspa_div;
 
 	if (params_rate(params) > 11025) {
 		freq_out  = params_rate(params) * 512;
@@ -63,7 +62,6 @@ static int brownstone_wm8994_hw_params(struct snd_pcm_substream *substream,
 		sysclk    = params_rate(params) * 512;
 		sspa_mclk = params_rate(params) * 64;
 	}
-	sspa_div = freq_out / sspa_mclk;
 
 	snd_soc_dai_set_sysclk(cpu_dai, MMP_SSPA_CLK_AUDIO, freq_out, 0);
 	snd_soc_dai_set_pll(cpu_dai, MMP_SYSCLK, 0, freq_out, sysclk);
-- 
2.7.0

Re: [PATCH RESEND] ASoC: pxa: remove unused variable

From: Mark Brown <broonie@kernel.org>
Date: 2016-02-26 01:19:11

On Thu, Feb 25, 2016 at 11:02:04PM +0100, Arnd Bergmann wrote:
Submitted originally on Nov 23 2015, this apparently got lost,
resending it now.
You didn't really submit it, you pasted it into the middle of a reply to
a message on an existing thread for a patch that was already applied:

https://lkml.org/lkml/2015/11/23/88

That's not really submitting a patch as far as I'm concerned, something
that won't just apply with git am without special faffing isn't helping
and things in the middle of threads aren't good either (it gets
difficult to follow and there's every chance they'll never even get seen
if they're buried in the middle of a reply where you don't expect to see
a patch).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160226/77c700e0/attachment-0001.sig>

Re: [PATCH RESEND] ASoC: pxa: remove unused variable

From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-02-26 13:47:03

On Friday 26 February 2016 10:18:27 Mark Brown wrote:
On Thu, Feb 25, 2016 at 11:02:04PM +0100, Arnd Bergmann wrote:
quoted
Submitted originally on Nov 23 2015, this apparently got lost,
resending it now.
You didn't really submit it, you pasted it into the middle of a reply to
a message on an existing thread for a patch that was already applied:

https://lkml.org/lkml/2015/11/23/88

That's not really submitting a patch as far as I'm concerned, something
that won't just apply with git am without special faffing isn't helping
and things in the middle of threads aren't good either (it gets
difficult to follow and there's every chance they'll never even get seen
if they're buried in the middle of a reply where you don't expect to see
a patch).
I see your point about the patch being in the middle of the thread.

Regarding the 'git am' compatibility, I thought I'd done it right,
but see now that I used incorrect scissors, apparently 'git mailinfo'
expects at least six '-' characters as the separator, while I used
just three.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help