Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

2 messages, 2 authors, 2016-02-20 · open the first message on its own page

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: 2016-02-20 18:22:22

Mark Brown [off-list ref] writes:
On Sat, Feb 20, 2016 at 03:37:56PM +0100, Robert Jarzmik wrote:
quoted
+WM9713 audio CODEC
+
+This devices supports I2C.
No, it clearly doesn't...
Right, it supports AC97.
The problem with doing this is that since AC'97 is an enumerable bus we really
shouldn't need to list AC'97 CODECs in the device tree.
Ok, I understand that.
Instead we should be probing at runtime (as the non-ASoC AC'97 code does) or
something similar.
When you say "non-ASoC AC'97 code", which file are you referring to ? Is it
sound/pci/ac97/ac97_codec.c ?

If so is there already a table of tuples (AC97_VENDOR_ID1, AC97_VENDOR_ID2) ->
(platform device, platform device data) and a matching mechanism already
available to the ASoC drivers ?

Cheers.

-- 
Robert

Re: [PATCH 1/4] ASoC: wm9713: add binding for WM9713 codec

From: Mark Brown <broonie@kernel.org>
Date: 2016-02-20 20:00:00

On Sat, Feb 20, 2016 at 07:22:04PM +0100, Robert Jarzmik wrote:
Mark Brown [off-list ref] writes:
quoted
Instead we should be probing at runtime (as the non-ASoC AC'97 code does) or
something similar.
When you say "non-ASoC AC'97 code", which file are you referring to ? Is it
sound/pci/ac97/ac97_codec.c ?
Yes.
If so is there already a table of tuples (AC97_VENDOR_ID1, AC97_VENDOR_ID2) ->
(platform device, platform device data) and a matching mechanism already
available to the ASoC drivers ?
ASoC doesn't really support the enumeration very well, you can use
ac97.c as the CODEC but that's about it.  There is a generic AC'97 PXA
driver in sound/arm, if your system can use that that'd be a better
route to DT integration for it I think.  Did you try that, if there are
problems with that perhaps we can improve that driver, it should  be
simpler.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160221/70f3d21d/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help