asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
explicitly include it causing build failures in -next where whatever was
causing it to be implicitly included has changed to remove that
inclusion. Add an explicit inclusion to fix this.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm64/include/asm/page.h | 2 ++
1 file changed, 2 insertions(+)
@@ -19,6 +19,8 @@#ifndef __ASM_PAGE_H#define __ASM_PAGE_H+#include<linux/personality.h>+/* PAGE_SHIFT determines the page size *//* CONT_SHIFT determines the number of pages which can be tracked together */#ifdef CONFIG_ARM64_64K_PAGES
On Thu, Jan 28, 2016 at 12:18:28PM +0000, Mark Brown wrote:
asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
explicitly include it causing build failures in -next where whatever was
causing it to be implicitly included has changed to remove that
inclusion. Add an explicit inclusion to fix this.
Argh, sorry - this causes problems further down the line with linking
vdso.lds due to enums getting into the linker script and upsetting the
linker (there are several compile errors today so it was masked).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160128/30ed13da/attachment.sig>
On Thu, Jan 28, 2016 at 12:44:17PM +0000, Mark Brown wrote:
On Thu, Jan 28, 2016 at 12:18:28PM +0000, Mark Brown wrote:
quoted
asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
explicitly include it causing build failures in -next where whatever was
causing it to be implicitly included has changed to remove that
inclusion. Add an explicit inclusion to fix this.
Argh, sorry - this causes problems further down the line with linking
vdso.lds due to enums getting into the linker script and upsetting the
linker (there are several compile errors today so it was masked).
You can move the include further down after the #ifndef __ASSEMBLY__
--
Catalin
On Thu, Jan 28, 2016 at 02:14:26PM +0000, Catalin Marinas wrote:
On Thu, Jan 28, 2016 at 12:44:17PM +0000, Mark Brown wrote:
quoted
On Thu, Jan 28, 2016 at 12:18:28PM +0000, Mark Brown wrote:
quoted
asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
explicitly include it causing build failures in -next where whatever was
causing it to be implicitly included has changed to remove that
inclusion. Add an explicit inclusion to fix this.
Argh, sorry - this causes problems further down the line with linking
vdso.lds due to enums getting into the linker script and upsetting the
linker (there are several compile errors today so it was masked).
You can move the include further down after the #ifndef __ASSEMBLY__
Indeed, here's what I've been using to successfully complete ARM64 test
builds:
From: Will Deacon <hidden> Date: 2016-02-02 16:48:18
On Thu, Jan 28, 2016 at 03:46:10PM +0100, Thierry Reding wrote:
quoted hunk
On Thu, Jan 28, 2016 at 02:14:26PM +0000, Catalin Marinas wrote:
quoted
On Thu, Jan 28, 2016 at 12:44:17PM +0000, Mark Brown wrote:
quoted
On Thu, Jan 28, 2016 at 12:18:28PM +0000, Mark Brown wrote:
quoted
asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
explicitly include it causing build failures in -next where whatever was
causing it to be implicitly included has changed to remove that
inclusion. Add an explicit inclusion to fix this.
Argh, sorry - this causes problems further down the line with linking
vdso.lds due to enums getting into the linker script and upsetting the
linker (there are several compile errors today so it was masked).
You can move the include further down after the #ifndef __ASSEMBLY__
Indeed, here's what I've been using to successfully complete ARM64 test
builds:
@@ -39,6 +39,7 @@#ifndef __ASSEMBLY__+#include<linux/personality.h>/* for READ_IMPLIES_EXEC */#include<asm/pgtable-types.h>externvoid__cpu_clear_user_page(void*p,unsignedlonguser);
I see this has ended up in linux-next, but I'm not sure whether or not
it's actually queued someplace for 4.6. Any ideas?
If not, I can take it (or some derivative) through arm64 as a fix for
-rc3.
Will
On Tue, 2 Feb 2016 16:48:18 +0000 Will Deacon [off-list ref] wrote:
On Thu, Jan 28, 2016 at 03:46:10PM +0100, Thierry Reding wrote:
quoted
On Thu, Jan 28, 2016 at 02:14:26PM +0000, Catalin Marinas wrote:
quoted
On Thu, Jan 28, 2016 at 12:44:17PM +0000, Mark Brown wrote:
quoted
On Thu, Jan 28, 2016 at 12:18:28PM +0000, Mark Brown wrote:
quoted
asm/page.h uses READ_IMPLIES_EXEC from linux/personality.h but does not
explicitly include it causing build failures in -next where whatever was
causing it to be implicitly included has changed to remove that
inclusion. Add an explicit inclusion to fix this.
Argh, sorry - this causes problems further down the line with linking
vdso.lds due to enums getting into the linker script and upsetting the
linker (there are several compile errors today so it was masked).
You can move the include further down after the #ifndef __ASSEMBLY__
Indeed, here's what I've been using to successfully complete ARM64 test
builds:
@@ -39,6 +39,7 @@#ifndef __ASSEMBLY__+#include<linux/personality.h>/* for READ_IMPLIES_EXEC */#include<asm/pgtable-types.h>externvoid__cpu_clear_user_page(void*p,unsignedlonguser);
I see this has ended up in linux-next, but I'm not sure whether or not
it's actually queued someplace for 4.6. Any ideas?
If not, I can take it (or some derivative) through arm64 as a fix for
-rc3.
It's not actually needed any more because Kirill has tweaked the patch
which triggered this build error.
However I think the change still makes sense as a standalone thing -
your call.
From: Andrew Morton <akpm@linux-foundation.org>
Subject: arm: arch/arm/include/asm/page.h needs personality.h
VM_DATA_DEFAULT_FLAGS uses READ_IMPLIES_EXEC, so page.h should include
personality.h to provide this.
This was needed for "mm: warn about VmData over RLIMIT_DATA".
Cc: Russell King <redacted>
Cc: Will Deacon <redacted>
Cc: Konstantin Khlebnikov <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/arm/include/asm/page.h | 2 ++
1 file changed, 2 insertions(+)
diff -puN arch/arm/include/asm/page.h~arm-arch-arm-include-asm-pageh-needs-personalityh arch/arm/include/asm/page.h