[PATCH v2] clk: Move vendor's Kconfig into CCF menu section

Subsystems: arm port, common clk framework, samsung soc clock drivers, the rest

STALE3891d

6 messages, 5 authors, 2016-02-16 · open the first message on its own page

[PATCH v2] clk: Move vendor's Kconfig into CCF menu section

From: James Liao <hidden>
Date: 2016-01-28 08:59:12

Move all vendor's Kconfig into CCF menu section to prevent
new drivers putting their Kconfig files in a wrong place.

Some Kconigs need to modify at the same time to avoid build
warnings.

Signed-off-by: James Liao <redacted>
---
This patch is based on v4.5-rc1.

changes since v1:
- Modify s3c24xx and samsung's Kconfig to avoid build warngings.

 arch/arm/mach-s3c24xx/Kconfig | 1 +
 drivers/clk/Kconfig           | 8 +++-----
 drivers/clk/samsung/Kconfig   | 1 -
 3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index ef68ecb..f02495f 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -15,6 +15,7 @@ config PLAT_S3C24XX
 	select NO_IOPORT_MAP
 	select S3C_DEV_NAND
 	select IRQ_DOMAIN
+	select COMMON_CLK
 	help
 	  Base platform code for any Samsung S3C24XX device
 
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index eca8e01..de707b2 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -202,11 +202,9 @@ config COMMON_CLK_CDCE706
 
 source "drivers/clk/bcm/Kconfig"
 source "drivers/clk/hisilicon/Kconfig"
-source "drivers/clk/qcom/Kconfig"
-
-endmenu
-
 source "drivers/clk/mvebu/Kconfig"
-
+source "drivers/clk/qcom/Kconfig"
 source "drivers/clk/samsung/Kconfig"
 source "drivers/clk/tegra/Kconfig"
+
+endmenu
diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
index 84196ec..b3fe5cb 100644
--- a/drivers/clk/samsung/Kconfig
+++ b/drivers/clk/samsung/Kconfig
@@ -1,6 +1,5 @@
 config COMMON_CLK_SAMSUNG
 	bool
-	select COMMON_CLK
 
 config S3C2410_COMMON_CLK
 	bool
-- 
1.9.1

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-01-28 11:29:08

On Thursday 28 January 2016 16:58:57 James Liao wrote:
Move all vendor's Kconfig into CCF menu section to prevent
new drivers putting their Kconfig files in a wrong place.

Some Kconigs need to modify at the same time to avoid build
warnings.

Signed-off-by: James Liao <redacted>
---
This patch is based on v4.5-rc1.

changes since v1:
- Modify s3c24xx and samsung's Kconfig to avoid build warngings.
Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date: 2016-01-28 13:00:02

On 28/01/16 09:58, James Liao wrote:
Move all vendor's Kconfig into CCF menu section to prevent
new drivers putting their Kconfig files in a wrong place.

Some Kconigs need to modify at the same time to avoid build
"Some Kconfigs need to be modified..." ?
warnings.

Signed-off-by: James Liao <redacted>
---
This patch is based on v4.5-rc1.

changes since v1:
- Modify s3c24xx and samsung's Kconfig to avoid build warngings.

 arch/arm/mach-s3c24xx/Kconfig | 1 +
 drivers/clk/Kconfig           | 8 +++-----
 drivers/clk/samsung/Kconfig   | 1 -
 3 files changed, 4 insertions(+), 6 deletions(-)
For the samsung code changes:

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

-- 
Thanks,
Sylwester

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

From: Stephen Boyd <hidden>
Date: 2016-01-30 00:30:27

On 01/28, James Liao wrote:
Move all vendor's Kconfig into CCF menu section to prevent
new drivers putting their Kconfig files in a wrong place.

Some Kconigs need to modify at the same time to avoid build
warnings.

Signed-off-by: James Liao <redacted>
---
Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

From: Krzysztof Kozlowski <hidden>
Date: 2016-02-16 04:59:17

2016-01-28 17:58 GMT+09:00 James Liao [off-list ref]:
Move all vendor's Kconfig into CCF menu section to prevent
new drivers putting their Kconfig files in a wrong place.

Some Kconigs need to modify at the same time to avoid build
warnings.

Signed-off-by: James Liao <redacted>
---
This patch is based on v4.5-rc1.

changes since v1:
- Modify s3c24xx and samsung's Kconfig to avoid build warngings.

 arch/arm/mach-s3c24xx/Kconfig | 1 +
 drivers/clk/Kconfig           | 8 +++-----
 drivers/clk/samsung/Kconfig   | 1 -
 3 files changed, 4 insertions(+), 6 deletions(-)
I wish you had used scripts/get_maintainer.pl to get list of people to CC...
Kukjin Kim [off-list ref] (maintainer:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES)
Krzysztof Kozlowski [off-list ref] (maintainer:ARM/SAMSUNG
EXYNOS ARM ARCHITECTURES)
linux-samsung-soc at vger.kernel.org (moderated list:ARM/SAMSUNG EXYNOS
ARM ARCHITECTURES)

Beside the fact that it is just nice and welcomed... it would help me
to avoid some of duplicated work...

Best regards,
Krzysztof

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

From: James Liao <hidden>
Date: 2016-02-16 05:46:11

Hi Krzysztof,

On Tue, 2016-02-16 at 13:59 +0900, Krzysztof Kozlowski wrote:
2016-01-28 17:58 GMT+09:00 James Liao [off-list ref]:
quoted
Move all vendor's Kconfig into CCF menu section to prevent
new drivers putting their Kconfig files in a wrong place.

Some Kconigs need to modify at the same time to avoid build
warnings.

Signed-off-by: James Liao <redacted>
---
This patch is based on v4.5-rc1.

changes since v1:
- Modify s3c24xx and samsung's Kconfig to avoid build warngings.

 arch/arm/mach-s3c24xx/Kconfig | 1 +
 drivers/clk/Kconfig           | 8 +++-----
 drivers/clk/samsung/Kconfig   | 1 -
 3 files changed, 4 insertions(+), 6 deletions(-)
I wish you had used scripts/get_maintainer.pl to get list of people to CC...
Kukjin Kim [off-list ref] (maintainer:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES)
Krzysztof Kozlowski [off-list ref] (maintainer:ARM/SAMSUNG
EXYNOS ARM ARCHITECTURES)
linux-samsung-soc at vger.kernel.org (moderated list:ARM/SAMSUNG EXYNOS
ARM ARCHITECTURES)

Beside the fact that it is just nice and welcomed... it would help me
to avoid some of duplicated work...
I'm sorry about that. I modified mach-s3c24xx/Kconfig and
samsung/Kconfig in patch v2 but I reused the TO and CC list from patch
v1, so this patch missed Samsung's maintainers.


Best regards,

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help