[PATCH] dts/ls1021a: add the DTS for QSPI support

Subsystems: the rest

STALE3904d

3 messages, 3 authors, 2016-02-02 · open the first message on its own page

[PATCH] dts/ls1021a: add the DTS for QSPI support

From: Yuan Yao <hidden>
Date: 2016-01-28 08:41:53

From: Yuan Yao <redacted>

Signed-off-by: Yuan Yao <redacted>
---
Add in v1:
Can merge, but the function depend on the patch:
https://patchwork.kernel.org/patch/8118251/

mtd: spi-nor: fsl-quadspi: add support for ls1021a

LS1021a also support Freescale Quad SPI controller.
Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
selectable for LS1021A SOC hardwares.

---
 arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 9430a99..c764fa5 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -252,6 +252,21 @@
 			status = "disabled";
 		};
 
+		qspi: quadspi at 1550000 {
+			compatible = "fsl,ls1021a-qspi";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x1550000 0x0 0x10000>,
+				<0x0 0x40000000 0x0 0x4000000>;
+			reg-names = "QuadSPI", "QuadSPI-memory";
+			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
+			clock-names = "qspi_en", "qspi";
+			clocks = <&platform_clk 1>, <&platform_clk 1>;
+			big-endian;
+			amba-base = <0x40000000>;
+			status = "disabled";
+		};
+
 		i2c0: i2c at 2180000 {
 			compatible = "fsl,vf610-i2c";
 			#address-cells = <1>;
-- 
2.1.0.27.g96db324

Re: [PATCH] dts/ls1021a: add the DTS for QSPI support

From: Shawn Guo <shawnguo@kernel.org>
Date: 2016-02-02 07:49:26

On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote:
From: Yuan Yao <redacted>

Signed-off-by: Yuan Yao <redacted>
---
Add in v1:
Can merge, but the function depend on the patch:
https://patchwork.kernel.org/patch/8118251/
Please send me dts patch only after the driver part gets applied.
quoted hunk
mtd: spi-nor: fsl-quadspi: add support for ls1021a

LS1021a also support Freescale Quad SPI controller.
Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
selectable for LS1021A SOC hardwares.

---
 arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 9430a99..c764fa5 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -252,6 +252,21 @@
 			status = "disabled";
 		};
 
+		qspi: quadspi at 1550000 {
+			compatible = "fsl,ls1021a-qspi";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x1550000 0x0 0x10000>,
+				<0x0 0x40000000 0x0 0x4000000>;
+			reg-names = "QuadSPI", "QuadSPI-memory";
+			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
+			clock-names = "qspi_en", "qspi";
+			clocks = <&platform_clk 1>, <&platform_clk 1>;
+			big-endian;
+			amba-base = <0x40000000>;
What is this property?  I cannot find it in any bindings doc.  Is it
added by your patches on driver code?

Shawn
+			status = "disabled";
+		};
+
 		i2c0: i2c at 2180000 {
 			compatible = "fsl,vf610-i2c";
 			#address-cells = <1>;
-- 
2.1.0.27.g96db324


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH] dts/ls1021a: add the DTS for QSPI support

From: Yao Yuan <hidden>
Date: 2016-02-02 11:44:46

On Tue, Feb 02, 2016 at 03:49PM, Shawn Guo wrote:
On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote:
quoted
From: Yuan Yao <redacted>

Signed-off-by: Yuan Yao <redacted>
---
Add in v1:
Can merge, but the function depend on the patch:
https://patchwork.kernel.org/patch/8118251/
Please send me dts patch only after the driver part gets applied.
Ok, I will resend the patch after the driver part gets applied.
I just only want to speed up my upstream.
quoted
mtd: spi-nor: fsl-quadspi: add support for ls1021a

LS1021a also support Freescale Quad SPI controller.
Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
selectable for LS1021A SOC hardwares.

---
 arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi
b/arch/arm/boot/dts/ls1021a.dtsi index 9430a99..c764fa5 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -252,6 +252,21 @@
 			status = "disabled";
 		};

+		qspi: quadspi at 1550000 {
+			compatible = "fsl,ls1021a-qspi";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x1550000 0x0 0x10000>,
+				<0x0 0x40000000 0x0 0x4000000>;
+			reg-names = "QuadSPI", "QuadSPI-memory";
+			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
+			clock-names = "qspi_en", "qspi";
+			clocks = <&platform_clk 1>, <&platform_clk 1>;
+			big-endian;
+			amba-base = <0x40000000>;
What is this property?  I cannot find it in any bindings doc.  Is it added by your
patches on driver code?
Sorry, it's the legacy property, after the latest discussion we will remove this property.
So I will remove it in the next version.
Thanks for your review.

Yuan Yao.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help