[PATCH 0/4] ARM: dts: imx53: update Ka-Ro electronics TX53 module support

STALE3910d

7 messages, 2 authors, 2016-02-02 · open the first message on its own page

[PATCH 0/4] ARM: dts: imx53: update Ka-Ro electronics TX53 module support

From: Lothar Waßmann <hidden>
Date: 2016-01-20 13:10:27

This patchset provides some bugfixes and support for a new display for
the Ka-Ro electronics TX53 modules.

ARM: dts: imx53: add ethernet PHY supply regulator
ARM: dts: imx53: fix LVDS data-mapping and data-width
ARM: dts: imx53: add display timing for NL12880BC20
ARM: dts: imx53-tx53: set correct mclk frequency

[PATCH 2/4] ARM: dts: imx53: fix LVDS data-mapping and data-width

From: Lothar Waßmann <hidden>
Date: 2016-01-20 13:10:21

Signed-off-by: Lothar Wa?mann <redacted>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index 6480471..6d0b526 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -183,13 +183,14 @@
 	status = "okay";
 
 	lvds0: lvds-channel at 0 {
-		fsl,data-mapping = "jeida";
-		fsl,data-width = <24>;
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <18>;
 		status = "okay";
 
 		display-timings {
-			native-mode = <&lvds_timing0>;
-			lvds_timing0: hsd100pxn1 {
+			native-mode = <&lvds0_timing0>;
+
+			lvds0_timing0: hsd100pxn1 {
 				clock-frequency = <65000000>;
 				hactive = <1024>;
 				vactive = <768>;
@@ -208,13 +209,14 @@
 	};
 
 	lvds1: lvds-channel at 1 {
-		fsl,data-mapping = "jeida";
-		fsl,data-width = <24>;
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <18>;
 		status = "okay";
 
 		display-timings {
-			native-mode = <&lvds_timing1>;
-			lvds_timing1: hsd100pxn1 {
+			native-mode = <&lvds1_timing0>;
+
+			lvds1_timing0: hsd100pxn1 {
 				clock-frequency = <65000000>;
 				hactive = <1024>;
 				vactive = <768>;
-- 
2.1.4

[PATCH 4/4] ARM: dts: imx53-tx53: set correct mclk frequency

From: Lothar Waßmann <hidden>
Date: 2016-01-20 13:10:29

The reference clock for the SGTL5000 is generated by a 26MHz crystal
oscillator on the Ka-Ro electronics STK5 eval kits. Use the correct
frequency setting in DTB.

Signed-off-by: Lothar Wa?mann <redacted>
---
 arch/arm/boot/dts/imx53-tx53.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index 8f08389..d15cc89 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -37,7 +37,7 @@
 			compatible = "fixed-clock";
 			reg = <0>;
 			#clock-cells = <0>;
-			clock-frequency = <27000000>;
+			clock-frequency = <26000000>;
 		};
 	};
 
-- 
2.1.4

[PATCH 1/4] ARM: dts: imx53: add ethernet PHY supply regulator

From: Lothar Waßmann <hidden>
Date: 2016-01-20 13:10:48

Signed-off-by: Lothar Wa?mann <redacted>
---
 arch/arm/boot/dts/imx53-tx53.dtsi | 40 ++++++++++++++++++++++++++++++---------
 1 file changed, 31 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index d3e50b2..8f08389 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -87,9 +87,20 @@
 			regulator-max-microvolt = <3300000>;
 		};
 
-		reg_can_xcvr: regulator at 2 {
+		reg_3v3_etn: regulator at 2 {
 			compatible = "regulator-fixed";
 			reg = <2>;
+			regulator-name = "ETN 3V3";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_etn_phy>;
+			gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
+		};
+
+		reg_can_xcvr: regulator at 3 {
+			compatible = "regulator-fixed";
+			reg = <3>;
 			regulator-name = "CAN XCVR";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
@@ -98,9 +109,9 @@
 			gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
 		};
 
-		reg_usbh1_vbus: regulator at 3 {
+		reg_usbh1_vbus: regulator at 4 {
 			compatible = "regulator-fixed";
-			reg = <3>;
+			reg = <4>;
 			regulator-name = "usbh1_vbus";
 			regulator-min-microvolt = <5000000>;
 			regulator-max-microvolt = <5000000>;
@@ -110,9 +121,9 @@
 			enable-active-high;
 		};
 
-		reg_usbotg_vbus: regulator at 4 {
+		reg_usbotg_vbus: regulator at 5 {
 			compatible = "regulator-fixed";
-			reg = <4>;
+			reg = <5>;
 			regulator-name = "usbotg_vbus";
 			regulator-min-microvolt = <5000000>;
 			regulator-max-microvolt = <5000000>;
@@ -204,13 +215,20 @@
 	phy-mode = "rmii";
 	phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
 	phy-handle = <&phy0>;
+	phy-supply = <&reg_3v3_etn>;
 	mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
 	status = "okay";
 
-	phy0: ethernet-phy at 0 {
-		interrupt-parent = <&gpio2>;
-		interrupts = <4>;
-		device_type = "ethernet-phy";
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy0: ethernet-phy at 0 {
+			compatible = "ethernet-phy-id0007.c0f1", "ethernet-phy-ieee802.3-c22";
+			reg = <0>;
+			interrupt-parent = <&gpio2>;
+			interrupts = <4>;
+		};
 	};
 };
 
@@ -309,6 +327,10 @@
 			fsl,pins = <MX53_PAD_DISP0_DAT0__GPIO4_21 0xe0>; /* Flexcan XCVR enable */
 		};
 
+		pinctrl_etn_phy: etn-phygrp {
+			fsl,pins = <MX53_PAD_EIM_D20__GPIO3_20 0xe0>; /* ETN PHY Power enable */
+		};
+
 		pinctrl_ds1339: ds1339grp {
 			fsl,pins = <MX53_PAD_DI0_PIN4__GPIO4_20 0xe0>;
 		};
-- 
2.1.4

[PATCH 3/4] ARM: dts: imx53: add display timing for NL12880BC20

From: Lothar Waßmann <hidden>
Date: 2016-01-20 13:11:09

Signed-off-by: Lothar Wa?mann <redacted>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index 6d0b526..97d531c 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -203,7 +203,23 @@
 				hsync-active = <0>;
 				vsync-active = <0>;
 				de-active = <1>;
-				pixelclk-active = <0>;
+				pixelclk-active = <1>;
+			};
+
+			lvds0_timing1: nl12880bc20 {
+				clock-frequency = <71000000>;
+				hactive = <1280>;
+				vactive = <800>;
+				hback-porch = <50>;
+				hsync-len = <60>;
+				hfront-porch = <50>;
+				vback-porch = <5>;
+				vsync-len = <13>;
+				vfront-porch = <5>;
+				hsync-active = <0>;
+				vsync-active = <0>;
+				de-active = <1>;
+				pixelclk-active = <1>;
 			};
 		};
 	};
@@ -229,7 +245,7 @@
 				hsync-active = <0>;
 				vsync-active = <0>;
 				de-active = <1>;
-				pixelclk-active = <0>;
+				pixelclk-active = <1>;
 			};
 		};
 	};
-- 
2.1.4

Re: [PATCH 1/4] ARM: dts: imx53: add ethernet PHY supply regulator

From: Shawn Guo <shawnguo@kernel.org>
Date: 2016-02-02 06:53:29

On Wed, Jan 20, 2016 at 02:09:19PM +0100, Lothar Wa?mann wrote:
quoted hunk
Signed-off-by: Lothar Wa?mann <redacted>
---
 arch/arm/boot/dts/imx53-tx53.dtsi | 40 ++++++++++++++++++++++++++++++---------
 1 file changed, 31 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index d3e50b2..8f08389 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -87,9 +87,20 @@
 			regulator-max-microvolt = <3300000>;
 		};
 
-		reg_can_xcvr: regulator at 2 {
+		reg_3v3_etn: regulator at 2 {
Why cannot this be added as regulator at 5 to avoid changing every node?
quoted hunk
 			compatible = "regulator-fixed";
 			reg = <2>;
+			regulator-name = "ETN 3V3";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_etn_phy>;
+			gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
+		};
+
+		reg_can_xcvr: regulator at 3 {
+			compatible = "regulator-fixed";
+			reg = <3>;
 			regulator-name = "CAN XCVR";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
@@ -98,9 +109,9 @@
 			gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
 		};
 
-		reg_usbh1_vbus: regulator at 3 {
+		reg_usbh1_vbus: regulator at 4 {
 			compatible = "regulator-fixed";
-			reg = <3>;
+			reg = <4>;
 			regulator-name = "usbh1_vbus";
 			regulator-min-microvolt = <5000000>;
 			regulator-max-microvolt = <5000000>;
@@ -110,9 +121,9 @@
 			enable-active-high;
 		};
 
-		reg_usbotg_vbus: regulator at 4 {
+		reg_usbotg_vbus: regulator at 5 {
 			compatible = "regulator-fixed";
-			reg = <4>;
+			reg = <5>;
 			regulator-name = "usbotg_vbus";
 			regulator-min-microvolt = <5000000>;
 			regulator-max-microvolt = <5000000>;
@@ -204,13 +215,20 @@
 	phy-mode = "rmii";
 	phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
 	phy-handle = <&phy0>;
+	phy-supply = <&reg_3v3_etn>;
 	mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
 	status = "okay";
 
-	phy0: ethernet-phy at 0 {
-		interrupt-parent = <&gpio2>;
-		interrupts = <4>;
-		device_type = "ethernet-phy";
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy0: ethernet-phy at 0 {
+			compatible = "ethernet-phy-id0007.c0f1", "ethernet-phy-ieee802.3-c22";
+			reg = <0>;
+			interrupt-parent = <&gpio2>;
+			interrupts = <4>;
+		};
This should be a separate change.

Shawn
quoted hunk
 	};
 };
 
@@ -309,6 +327,10 @@
 			fsl,pins = <MX53_PAD_DISP0_DAT0__GPIO4_21 0xe0>; /* Flexcan XCVR enable */
 		};
 
+		pinctrl_etn_phy: etn-phygrp {
+			fsl,pins = <MX53_PAD_EIM_D20__GPIO3_20 0xe0>; /* ETN PHY Power enable */
+		};
+
 		pinctrl_ds1339: ds1339grp {
 			fsl,pins = <MX53_PAD_DI0_PIN4__GPIO4_20 0xe0>;
 		};
-- 
2.1.4

Re: [PATCH 0/4] ARM: dts: imx53: update Ka-Ro electronics TX53 module support

From: Shawn Guo <shawnguo@kernel.org>
Date: 2016-02-02 07:01:53

On Wed, Jan 20, 2016 at 02:09:18PM +0100, Lothar Wa?mann wrote:
ARM: dts: imx53: fix LVDS data-mapping and data-width
ARM: dts: imx53: add display timing for NL12880BC20
ARM: dts: imx53-tx53: set correct mclk frequency
Applied these 3, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help