[PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()

Subsystems: clocksource, clockevent drivers, the rest

STALE3930d

3 messages, 3 authors, 2016-01-19 · open the first message on its own page

[PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()

From: Alexandre Belloni <hidden>
Date: 2016-01-18 19:35:08

ret is used to detect an error but it was not properly updated after
calling clk_prepare_enable() thus it made it impossible to detect an error
when enabling the slow clock.

Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/clocksource/timer-atmel-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index 29d21d68df5a..c69070c6ad91 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node)
 	if (IS_ERR(sclk))
 		panic(pr_fmt("Unable to get slow clock\n"));
 
-	clk_prepare_enable(sclk);
+	ret = clk_prepare_enable(sclk);
 	if (ret)
 		panic(pr_fmt("Could not enable slow clock\n"));
 
-- 
2.5.0

Re: [PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()

From: Nicolas Ferre <hidden>
Date: 2016-01-19 08:33:46

Le 18/01/2016 20:34, Alexandre Belloni a ?crit :
quoted hunk
ret is used to detect an error but it was not properly updated after
calling clk_prepare_enable() thus it made it impossible to detect an error
when enabling the slow clock.

Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/clocksource/timer-atmel-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
index 29d21d68df5a..c69070c6ad91 100644
--- a/drivers/clocksource/timer-atmel-st.c
+++ b/drivers/clocksource/timer-atmel-st.c
@@ -225,7 +225,7 @@ static void __init atmel_st_timer_init(struct device_node *node)
 	if (IS_ERR(sclk))
 		panic(pr_fmt("Unable to get slow clock\n"));
 
-	clk_prepare_enable(sclk);
+	ret = clk_prepare_enable(sclk);
Yes, sure...
Acked-by: Nicolas Ferre <redacted>

Thanks!

 	if (ret)
 		panic(pr_fmt("Could not enable slow clock\n"));
 

-- 
Nicolas Ferre

Re: [PATCH] clocksource: atmel-st: use return value from clk_prepare_enable()

From: Daniel Lezcano <hidden>
Date: 2016-01-19 08:49:57

On 01/18/2016 08:34 PM, Alexandre Belloni wrote:
ret is used to detect an error but it was not properly updated after
calling clk_prepare_enable() thus it made it impossible to detect an error
when enabling the slow clock.

Signed-off-by: Alexandre Belloni <redacted>
---
Applied thanks !

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help