quoted
quoted
quoted
quoted
"Wenyou" == Wenyou Yang [off-list ref] writes:
> This patch adds new regulator driver to support ACT8945A MFD
> chip's regulators.
> The ACT8945A has three step-down DC/DC converters and four
> low-dropout regulators.
> Signed-off-by: Wenyou Yang [off-list ref]
Isn't the regulator part of the act8945a identical to act8865? Can't we
just use the existing act8865-regulator.c driver? (E.G. support 8865
variant in the mfd driver, but only register the regulator sub device?)
--
Bye, Peter Korsgaard
-----Original Message-----
From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard
Sent: 2016?1?13? 22:22
To: Yang, Wenyou <redacted>
Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
Rob Herring [off-list ref]; Pawel Moll [off-list ref]; Mark
Rutland [off-list ref]; Ian Campbell [off-list ref];
Kumar Gala [off-list ref]; Krzysztof Kozlowski
[off-list ref]; devicetree at vger.kernel.org; Ferre, Nicolas
[off-list ref]; linux-kernel at vger.kernel.org; Javier Martinez
Canillas [off-list ref]; Lee Jones [off-list ref]; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
ACT8945A
quoted
quoted
quoted
quoted
quoted
"Wenyou" == Wenyou Yang [off-list ref] writes:
> This patch adds new regulator driver to support ACT8945A MFD > chip's
regulators.
> The ACT8945A has three step-down DC/DC converters and four > low-dropout
regulators.
> Signed-off-by: Wenyou Yang [off-list ref]
Isn't the regulator part of the act8945a identical to act8865? Can't we just use the
existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd driver,
but only register the regulator sub device?)
Yes, the regulator part of the act8945a is identical to act8865.
But the act8865-regulator driver is a struct i2c_driver, and the mfd sub-device driver is a platform_driver driver, it is not easy to use it.
--
Bye, Peter Korsgaard
Best Regards,
Wenyou Yang
On Thu, 14 Jan 2016, Yang, Wenyou wrote:
quoted
-----Original Message-----
From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard
Sent: 2016?1?13? 22:22
To: Yang, Wenyou <redacted>
Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
Rob Herring [off-list ref]; Pawel Moll [off-list ref]; Mark
Rutland [off-list ref]; Ian Campbell [off-list ref];
Kumar Gala [off-list ref]; Krzysztof Kozlowski
[off-list ref]; devicetree at vger.kernel.org; Ferre, Nicolas
[off-list ref]; linux-kernel at vger.kernel.org; Javier Martinez
Canillas [off-list ref]; Lee Jones [off-list ref]; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
ACT8945A
quoted
quoted
quoted
quoted
quoted
"Wenyou" == Wenyou Yang [off-list ref] writes:
> This patch adds new regulator driver to support ACT8945A MFD > chip's
regulators.
> The ACT8945A has three step-down DC/DC converters and four > low-dropout
regulators.
> Signed-off-by: Wenyou Yang [off-list ref]
Isn't the regulator part of the act8945a identical to act8865? Can't we just use the
existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd driver,
but only register the regulator sub device?)
Yes, the regulator part of the act8945a is identical to act8865.
But the act8865-regulator driver is a struct i2c_driver, and the mfd sub-device driver is a platform_driver driver, it is not easy to use it.
Take a look at some existing files with the pattern
drivers/mfd/*{spi,i2c,core}.c to see how this might be possible.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog