From: Krzysztof Kozlowski <hidden> Date: 2016-01-07 02:15:35
Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
which should bring performance benefits on Exynos SoCs. Enable these as
modules because they are optional, not essential anyhow for platform
booting nor related directly to Exynos Soc. All accelerated algorithms
pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
Additionally enable cpufreq statistics as they are useful for debugging.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
arch/arm/configs/exynos_defconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
From: Krzysztof Kozlowski <hidden> Date: 2016-01-07 02:15:44
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.
Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
The cbc-aes-s5p properly registers itself and passes self-tests.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
Hi Krzysztof,
On 7 January 2016 at 07:45, Krzysztof Kozlowski [off-list ref] wrote:
quoted hunk
Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
which should bring performance benefits on Exynos SoCs. Enable these as
modules because they are optional, not essential anyhow for platform
booting nor related directly to Exynos Soc. All accelerated algorithms
pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
Additionally enable cpufreq statistics as they are useful for debugging.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
arch/arm/configs/exynos_defconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Hi Krzysztof,
On 7 January 2016 at 07:45, Krzysztof Kozlowski [off-list ref] wrote:
quoted hunk
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.
Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
The cbc-aes-s5p properly registers itself and passes self-tests.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
From: Javier Martinez Canillas <hidden> Date: 2016-01-08 15:33:04
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
Enable the kernel NEON mode and asm/NEON accelerated crypto algorithms
which should bring performance benefits on Exynos SoCs. Enable these as
modules because they are optional, not essential anyhow for platform
booting nor related directly to Exynos Soc. All accelerated algorithms
pass booting self-tests on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412).
Additionally enable cpufreq statistics as they are useful for debugging.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
Reviewed-by: Javier Martinez Canillas <redacted>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
From: Javier Martinez Canillas <hidden> Date: 2016-01-08 15:35:24
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
quoted hunk
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.
Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
The cbc-aes-s5p properly registers itself and passes self-tests.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
From: Krzysztof Kozlowski <hidden> Date: 2016-01-09 02:46:14
2016-01-09 0:35 GMT+09:00 Javier Martinez Canillas [off-list ref]:
Hello Krzysztof,
On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
quoted
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.
Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
The cbc-aes-s5p properly registers itself and passes self-tests.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1 insertion(+)
I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?
Thanks for feedback and review. I noticed that as well but I am not
convinced because one of two of supported algorithms fails the
tests... which makes 50% of driver non-working. :) Maybe it is
harmless - just pollutes the dmesg... Maybe after fixing it.
Best regards,
Krzysztof
I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?
Thanks for feedback and review. I noticed that as well but I am not
convinced because one of two of supported algorithms fails the
tests... which makes 50% of driver non-working. :) Maybe it is
harmless - just pollutes the dmesg... Maybe after fixing it.
Agreed that can be done after fixing the driver.
Best regards,
Krzysztof
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America