Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

2 messages, 2 authors, 2015-10-08 · open the first message on its own page

Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

From: khalasa@piap.pl (Krzysztof Hałasa)
Date: 2015-10-08 10:03:27

Hi,

Arnd Bergmann [off-list ref] writes:
With those two changes in place, we no longer need the fake
pci_sys_data/pci_bus structures for faking config space writes,
and the stack usage goes down as well.
 arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------
I'm ATM unable to test this change, but will do that at some point.
Meanwhile, I guess there is nothing I can say against this patch.
Thanks.

Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

From: Arnd Bergmann <arnd@arndb.de>
Date: 2015-10-08 14:38:37

On Thursday 08 October 2015 12:03:18 Krzysztof Ha?asa wrote:
Hi,

Arnd Bergmann [off-list ref] writes:
quoted
With those two changes in place, we no longer need the fake
pci_sys_data/pci_bus structures for faking config space writes,
and the stack usage goes down as well.
quoted
 arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------
I'm ATM unable to test this change, but will do that at some point.
Meanwhile, I guess there is nothing I can say against this patch.
Thanks.

Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
Thanks! I've queued it up in next/fixes-non-critical for linux-4.4
now, if you find something wrong later, we can revert or fix up.

There is no urgency for this one, especially since you still want to
test it, so no reason to put it in 4.3.

This was the last pre-2015 build warning for the ARM defconfigs
and allmodconfig, all remaining warnings are regressions or new
code, and I've submitted patches for those. Let's see if we can
get to a warning-free kernel build in 4.4.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help