# \[PATCH 1/2\] Add a matching set of device\_ functions for determining mac/phy

- From: Florian Fainelli \<f.fainelli@gmail.com\>
- Date: 2015-08-12 22:13:56 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2015/08/8718782
- Thread: https://ratatoskr.run/linux-arm-kernel/2015/08/8718778/t.md

```text
On 12/08/15 15:06, Jeremy Linton wrote:
> OF has some helper functions for parsing MAC and PHY settings.
> In cases where the platform is providing this information rather
> than the device itself, there needs to be similar functions for ACPI.
> 
> These functions are slightly modified versions of the ones in
> of_net which can use information provided via DT or ACPI.
> 
> Signed-off-by: Jeremy Linton <redacted>
> ---

[snip]

> +
> +static void *device_get_mac_addr(struct device *dev,
> +				 const char *name, char *addr,
> +				 int alen)
> +{
> +	int ret = device_property_read_u8_array(dev, name, addr, alen);
> +
> +	if (ret == 0 && is_valid_ether_addr(addr))
> +		return addr;
> +	return NULL;

The DT counterpart has an additional check on the properly length to be
ETH_ALEN, you might want to have such check here for consistency and
correctness.

Other than that, this looks good to me.
-- 
Florian
```