[PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

Subsystems: the rest

STALE4098d REVIEWED: 1 (0M)

1 review trailer.

3 messages, 3 authors, 2015-05-16 · open the first message on its own page

[PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

From: Tomeu Vizoso <hidden>
Date: 2015-05-14 12:41:56

Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
adding support for PMU regmap") the syscon property is required in
samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
yet.

Signed-off-by: Tomeu Vizoso <redacted>
Reviewed-by: Javier Martinez Canillas <redacted>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Krzysztof Koz?owski <redacted>

--

v2:	* Remove reg property as suggested by Javier
	* Added his Reviewed-by
---
 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 4531753..78bcbc0 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -541,7 +541,7 @@
 
 	mipi_phy: video-phy at 10040714 {
 		compatible = "samsung,s5pv210-mipi-video-phy";
-		reg = <0x10040714 12>;
+		syscon = <&pmu_system_controller>;
 		#phy-cells = <1>;
 	};
 
-- 
2.4.0

Re: [PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

From: Krzysztof Kozlowski <hidden>
Date: 2015-05-15 13:22:43

2015-05-14 21:40 GMT+09:00 Tomeu Vizoso [off-list ref]:
Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
adding support for PMU regmap") the syscon property is required in
samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
yet.

Signed-off-by: Tomeu Vizoso <redacted>
Reviewed-by: Javier Martinez Canillas <redacted>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Krzysztof Koz?owski <redacted>

--
Triple-dash please, because this won't be cut by "git am".

Everything else looks fine, thank you.
Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof

Re: [PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

From: Kukjin Kim <kgene@kernel.org>
Date: 2015-05-16 03:27:41

On 05/15/15 22:22, Krzysztof Kozlowski wrote:
2015-05-14 21:40 GMT+09:00 Tomeu Vizoso [off-list ref]:
quoted
Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
adding support for PMU regmap") the syscon property is required in
samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
yet.

Signed-off-by: Tomeu Vizoso <redacted>
Reviewed-by: Javier Martinez Canillas <redacted>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Krzysztof Koz?owski <redacted>

--
Triple-dash please, because this won't be cut by "git am".

Everything else looks fine, thank you.
Reviewed-by: Krzysztof Kozlowski <redacted>
Applied, thanks for you guys' effort.

- Kukjin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help