[PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes
From: Wolfram Sang <hidden>
Date: 2015-03-20 10:19:07
Also in:
linux-devicetree, linux-i2c, lkml
From: Wolfram Sang <hidden>
Date: 2015-03-20 10:19:07
Also in:
linux-devicetree, linux-i2c, lkml
Ok, I see what you mean. I had a look at the place in question and wonder what to return from i2c_add_mux_adapter() in the disabled case so that i2c-mux-pinctrl is still happy with the returned value.
Ouch, you are right. The crux of interfaces returning NULL instead of an ERR_PTR :( I'll have a look, I maybe started to fix this somewhen.
I guess what you want to have is that i2c_add_adapter() is not called for the disabled case, right?
I think that makes sense.
Is the i2c_adapter struct prepared in i2c_mux_add_adapter() still valid if i2c_add_adapter() is not called?
I will have a closer look to the issue this weekend.
Sorry, I am not too deep into i2c subsystem, I just reworked i2c-mux- pinctrl to make it work on Dove. If you are fine with giving me some guidance how you prefer to have it done, I can try to free some spare time.
Cool, thanks. Learning by doing is a good way to get such knowledge :)
Unfortunately there is already little of it, so please don't expect a quick tested patch.
I understand. Thanks, Wolfram -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150320/9241a8b2/attachment.sig>