From: Daniel Lezcano <hidden> Date: 2014-09-11 09:32:48
On 09/11/2014 10:57 AM, Lorenzo Pieralisi wrote:
On Thu, Sep 11, 2014 at 09:28:06AM +0100, Daniel Lezcano wrote:
quoted
On 09/05/2014 05:34 PM, Lorenzo Pieralisi wrote:
quoted
On Fri, Sep 05, 2014 at 10:21:20AM +0100, Will Deacon wrote:
quoted
On Thu, Sep 04, 2014 at 06:29:10PM +0100, Lorenzo Pieralisi wrote:
quoted
On Thu, Sep 04, 2014 at 05:03:20PM +0100, Catalin Marinas wrote:
quoted
On Wed, Sep 03, 2014 at 06:37:40PM +0100, Lorenzo Pieralisi wrote:
quoted
This patch should be ready to go too, is it ok if I split the series
in arm64 arch specific patches (will ask Catalin to pull) and CPUidle ones
(inclusive of DT bindings and !!this patch!!) and send two separate pull
requests ?
If Daniel/Rafael don't have any objection, I can take the whole series
through the arm64 tree (it seems that patches have been already acked by
Daniel).
Thanks a lot Catalin. Since this one is a brand new CPUidle driver and it
follows a different pattern from arm legacy drivers I would like to get
Daniel's ack on this patch too before pushing it. For the records I have
just added two pr_err to signal driver probing error, ultraminor changes
that do not justify a repost.
If Samsung guys do not manifest themselves I would drop patch 8 from
the series till it gets tested and its patch dependency queued too.
The last patch also has a dependency, as you mentioned to Daniel. I think
we can certainly merge the arm64 parts, and if Daniel doesn't object, then
we can take the driver stuff too but leaving the exynos bits out (i.e. drop
the last patch).
Anyway, if you could repost with the acks you've collected and rearrange it
so the arm64 patches are first in the series, that would be great.
I can repost it with the acks and rearrange the patches, but for the
pull request I have to know what code can be merged, since there are
some arm64 patches (PSCI and CPUidle arm64 back-end) that are strictly
tied to the arm64 CPUidle driver, so I *have* to know if the arm64
CPUidle driver (this patch) can get merged and that requires an ack.
If I do not hear from Samsung guys I will drop patch 8.
Well I would prefer to have this patch merged (Cc'ing Tomasz).
I will wait till Monday (ie -rc4) and repost, I hope that's acceptable.
There is a procedure to solve this branch dependency.
1. Create a patchset with only the changes in drivers/cpuidle (+ misc dt
stuff)
2. Send the patchset to me.
Ok. I will do it straight away.
quoted
3. I create a branch with these patches (which will be merged in my
cpuidle next branch)
4. Merge this branch to a new branch (based on 3.17-rcX) and put on top
of that your changes for ARM[64]
5. Send the PR to Catalin and Arnd (one for each branch or one for both
arch)
There is no ARM code in my series. So to sum it up:
a) I send a pull request to Catalin for arm64 patches on top of the branch
you are creating with my patches
>
b) You take care of merging the CPUidle related patches through your
tree
Is the above what you meant ?
Right, that allows to share a branch across the trees and resolve the
dependencies when a patchset is touching different subsystems.
I realize the dependency is inverted regarding what I proposed
initially, so it is up to Catalin to create the branch and I will share
it with him.
I will send you an mbox for CPUidle related patches straight away (well,
as soon as I know what to do with patch 8).
Daniel, Lorenzo,
On Thu, Sep 11, 2014 at 10:32:48AM +0100, Daniel Lezcano wrote:
On 09/11/2014 10:57 AM, Lorenzo Pieralisi wrote:
quoted
There is no ARM code in my series. So to sum it up:
a) I send a pull request to Catalin for arm64 patches on top of the branch
you are creating with my patches
>
quoted
b) You take care of merging the CPUidle related patches through your
tree
Is the above what you meant ?
Right, that allows to share a branch across the trees and resolve the
dependencies when a patchset is touching different subsystems.
I realize the dependency is inverted regarding what I proposed
initially, so it is up to Catalin to create the branch and I will share
it with him.
I created the branch below with the arm64 specific patches for cpuidle.
I won't rebase it and it should appear in -next tomorrow.
Lorenzo, please send a pull request to Daniel with the additional
patches on top of the arm64 branch. Thanks.
The following changes since commit 2ce7598c9a453e0acd0e07be7be3f5eb39608ebd:
Linux 3.17-rc4 (2014-09-07 16:09:43 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux for-next/cpuidle
for you to fetch changes up to 18910ab0d916b1a87016d69efd027714a80521dd:
arm64: add PSCI CPU_SUSPEND based cpu_suspend support (2014-09-12 10:48:56 +0100)
----------------------------------------------------------------
Lorenzo Pieralisi (4):
Documentation: arm: define DT idle states bindings
arm64: kernel: refactor the CPU suspend API for retention states
arm64: kernel: introduce cpu_init_idle CPU operation
arm64: add PSCI CPU_SUSPEND based cpu_suspend support
Documentation/devicetree/bindings/arm/cpus.txt | 8 +
.../devicetree/bindings/arm/idle-states.txt | 679 +++++++++++++++++++++
Documentation/devicetree/bindings/arm/psci.txt | 14 +-
arch/arm64/include/asm/cpu_ops.h | 3 +
arch/arm64/include/asm/cpuidle.h | 13 +
arch/arm64/include/asm/suspend.h | 1 +
arch/arm64/kernel/Makefile | 1 +
arch/arm64/kernel/cpuidle.c | 31 +
arch/arm64/kernel/psci.c | 104 ++++
arch/arm64/kernel/sleep.S | 47 +-
arch/arm64/kernel/suspend.c | 48 +-
11 files changed, 916 insertions(+), 33 deletions(-)
create mode 100644 Documentation/devicetree/bindings/arm/idle-states.txt
create mode 100644 arch/arm64/include/asm/cpuidle.h
create mode 100644 arch/arm64/kernel/cpuidle.c
--
Catalin
From: Lorenzo Pieralisi <hidden> Date: 2014-09-12 11:26:43
On Fri, Sep 12, 2014 at 11:32:57AM +0100, Catalin Marinas wrote:
Daniel, Lorenzo,
On Thu, Sep 11, 2014 at 10:32:48AM +0100, Daniel Lezcano wrote:
quoted
On 09/11/2014 10:57 AM, Lorenzo Pieralisi wrote:
quoted
There is no ARM code in my series. So to sum it up:
a) I send a pull request to Catalin for arm64 patches on top of the branch
you are creating with my patches
>
quoted
b) You take care of merging the CPUidle related patches through your
tree
Is the above what you meant ?
Right, that allows to share a branch across the trees and resolve the
dependencies when a patchset is touching different subsystems.
I realize the dependency is inverted regarding what I proposed
initially, so it is up to Catalin to create the branch and I will share
it with him.
I created the branch below with the arm64 specific patches for cpuidle.
I won't rebase it and it should appear in -next tomorrow.
Lorenzo, please send a pull request to Daniel with the additional
patches on top of the arm64 branch. Thanks.
Thank you very much, done. Pull request attached for information.
As Daniel knows, last two patches are still pending, waiting for Samsung
acks, and will be dropped if we do not get them in time.
Lorenzo
The following changes since commit 18910ab0d916b1a87016d69efd027714a80521dd:
arm64: add PSCI CPU_SUSPEND based cpu_suspend support (2014-09-12 10:48:56 +0100)
are available in the git repository at:
git://linux-arm.org/linux-2.6-lp.git for-upstream/arm-generic-cpuidle
for you to fetch changes up to dda773655f9b97570884c4396ad4d63daf177107:
drivers: cpuidle: initialize Exynos driver through DT (2014-09-12 11:37:43 +0100)
----------------------------------------------------------------
Bartlomiej Zolnierkiewicz (1):
ARM: dts: add CPU nodes for Exynos4 SoCs
Lorenzo Pieralisi (4):
drivers: cpuidle: implement DT based idle states infrastructure
drivers: cpuidle: CPU idle ARM64 driver
drivers: cpuidle: initialize big.LITTLE driver through DT
drivers: cpuidle: initialize Exynos driver through DT
arch/arm/boot/dts/exynos4210.dtsi | 27 ++++
arch/arm/boot/dts/exynos4212.dtsi | 17 +++
arch/arm/boot/dts/exynos4412.dtsi | 29 ++++
arch/arm/boot/dts/exynos5250.dtsi | 11 ++
arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts | 23 ++++
drivers/cpuidle/Kconfig | 8 ++
drivers/cpuidle/Kconfig.arm | 2 +
drivers/cpuidle/Kconfig.arm64 | 14 ++
drivers/cpuidle/Makefile | 5 +
drivers/cpuidle/cpuidle-arm64.c | 133 ++++++++++++++++++
drivers/cpuidle/cpuidle-big_little.c | 19 +++
drivers/cpuidle/cpuidle-exynos.c | 18 ++-
drivers/cpuidle/dt_idle_states.c | 213 +++++++++++++++++++++++++++++
drivers/cpuidle/dt_idle_states.h | 7 +
14 files changed, 525 insertions(+), 1 deletion(-)
create mode 100644 drivers/cpuidle/Kconfig.arm64
create mode 100644 drivers/cpuidle/cpuidle-arm64.c
create mode 100644 drivers/cpuidle/dt_idle_states.c
create mode 100644 drivers/cpuidle/dt_idle_states.h
Hi,
On Friday, September 12, 2014 12:26:43 PM Lorenzo Pieralisi wrote:
On Fri, Sep 12, 2014 at 11:32:57AM +0100, Catalin Marinas wrote:
quoted
Daniel, Lorenzo,
On Thu, Sep 11, 2014 at 10:32:48AM +0100, Daniel Lezcano wrote:
quoted
On 09/11/2014 10:57 AM, Lorenzo Pieralisi wrote:
quoted
There is no ARM code in my series. So to sum it up:
a) I send a pull request to Catalin for arm64 patches on top of the branch
you are creating with my patches
>
quoted
b) You take care of merging the CPUidle related patches through your
tree
Is the above what you meant ?
Right, that allows to share a branch across the trees and resolve the
dependencies when a patchset is touching different subsystems.
I realize the dependency is inverted regarding what I proposed
initially, so it is up to Catalin to create the branch and I will share
it with him.
I created the branch below with the arm64 specific patches for cpuidle.
I won't rebase it and it should appear in -next tomorrow.
Lorenzo, please send a pull request to Daniel with the additional
patches on top of the arm64 branch. Thanks.
Thank you very much, done. Pull request attached for information.
As Daniel knows, last two patches are still pending, waiting for Samsung
acks, and will be dropped if we do not get them in time.
Lorenzo
The following changes since commit 18910ab0d916b1a87016d69efd027714a80521dd:
arm64: add PSCI CPU_SUSPEND based cpu_suspend support (2014-09-12 10:48:56 +0100)
are available in the git repository at:
git://linux-arm.org/linux-2.6-lp.git for-upstream/arm-generic-cpuidle
for you to fetch changes up to dda773655f9b97570884c4396ad4d63daf177107:
drivers: cpuidle: initialize Exynos driver through DT (2014-09-12 11:37:43 +0100)
----------------------------------------------------------------
Bartlomiej Zolnierkiewicz (1):
ARM: dts: add CPU nodes for Exynos4 SoCs
This patch got broken during merge. It differs from the version I posted
on the list by not having the closing "};" which causes a dtb build failure:
Error: arch/arm/boot/dts/exynos4210-origen.dts:21.1-2 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/exynos4210-origen.dtb] Error 1
make: *** [dtbs] Error 2
make: *** Waiting for unfinished jobs....
Please regenarate your branch with the fixed version of the patch
(you can squash the fix below to the broken patch).
---
arch/arm/boot/dts/exynos4210.dtsi | 1 +
1 file changed, 1 insertion(+)
Index: b/arch/arm/boot/dts/exynos4210.dtsi
===================================================================
From: Lorenzo Pieralisi <hidden> Date: 2014-09-23 18:14:47
On Tue, Sep 23, 2014 at 02:35:14PM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Friday, September 12, 2014 12:26:43 PM Lorenzo Pieralisi wrote:
quoted
On Fri, Sep 12, 2014 at 11:32:57AM +0100, Catalin Marinas wrote:
quoted
Daniel, Lorenzo,
On Thu, Sep 11, 2014 at 10:32:48AM +0100, Daniel Lezcano wrote:
quoted
On 09/11/2014 10:57 AM, Lorenzo Pieralisi wrote:
quoted
There is no ARM code in my series. So to sum it up:
a) I send a pull request to Catalin for arm64 patches on top of the branch
you are creating with my patches
>
quoted
b) You take care of merging the CPUidle related patches through your
tree
Is the above what you meant ?
Right, that allows to share a branch across the trees and resolve the
dependencies when a patchset is touching different subsystems.
I realize the dependency is inverted regarding what I proposed
initially, so it is up to Catalin to create the branch and I will share
it with him.
I created the branch below with the arm64 specific patches for cpuidle.
I won't rebase it and it should appear in -next tomorrow.
Lorenzo, please send a pull request to Daniel with the additional
patches on top of the arm64 branch. Thanks.
Thank you very much, done. Pull request attached for information.
As Daniel knows, last two patches are still pending, waiting for Samsung
acks, and will be dropped if we do not get them in time.
Lorenzo
The following changes since commit 18910ab0d916b1a87016d69efd027714a80521dd:
arm64: add PSCI CPU_SUSPEND based cpu_suspend support (2014-09-12 10:48:56 +0100)
are available in the git repository at:
git://linux-arm.org/linux-2.6-lp.git for-upstream/arm-generic-cpuidle
for you to fetch changes up to dda773655f9b97570884c4396ad4d63daf177107:
drivers: cpuidle: initialize Exynos driver through DT (2014-09-12 11:37:43 +0100)
----------------------------------------------------------------
Bartlomiej Zolnierkiewicz (1):
ARM: dts: add CPU nodes for Exynos4 SoCs
This patch got broken during merge. It differs from the version I posted
on the list by not having the closing "};" which causes a dtb build failure:
Error: arch/arm/boot/dts/exynos4210-origen.dts:21.1-2 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/exynos4210-origen.dtb] Error 1
make: *** [dtbs] Error 2
make: *** Waiting for unfinished jobs....
Please regenarate your branch with the fixed version of the patch
(you can squash the fix below to the broken patch).
I won't regenerate the branch, Daniel knows that the last two patches
(Samsung changes) were subject to testing and he has an mbox (and the
branch above) that he can use to cherry-pick the patches going through
his tree, as planned.
Daniel, can you squash the fix below into Bart's original patch (that is
part of the mbox I sent you and also part of the pull request) and
stick his tested-by to the Exynos DT CPUidle patch (last in the series)
please ?
I won't be able to regenerate a pull request till Monday, and honestly
there is no need for that.
Thanks a lot,
Lorenzo