[PATCH v3] Documentation: devicetree: Fix ADI AXI SPDIF specification

Subsystems: analog devices inc asoc codec drivers, open firmware and flattened device tree bindings, sound - soc layer / dynamic audio power management (asoc), the rest

STALE4405d REVIEWED: 5 (4M)

2 review trailers (1 from subsystem maintainers).

2 messages, 2 authors, 2014-08-16 · open the first message on its own page

[PATCH v3] Documentation: devicetree: Fix ADI AXI SPDIF specification

From: Andreas Färber <afaerber@suse.de>
Date: 2014-07-28 13:05:23

The specification requires compatible = "adi,axi-spdif-1.00.a" but
driver and example and file name indicate "adi,axi-spdif-tx-1.00.a".
Change the specification to match the implementation.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Michal Simek <redacted>
Fixes: d7b528eff927 ("dt: Add bindings documentation for the ADI AXI-SPDIF audio controller")
Signed-off-by: Andreas F?rber <afaerber@suse.de>
---
 v2 -> v3:
 * Added Fixes header
 * CC broonie (Mark Brown)
 
 v2: New
 
 Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt b/Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt
index 46f344965313..4eb7997674a0 100644
--- a/Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt
+++ b/Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt
@@ -1,7 +1,7 @@
 ADI AXI-SPDIF controller
 
 Required properties:
- - compatible : Must be "adi,axi-spdif-1.00.a"
+ - compatible : Must be "adi,axi-spdif-tx-1.00.a"
  - reg : Must contain SPDIF core's registers location and length
  - clocks : Pairs of phandle and specifier referencing the controller's clocks.
    The controller expects two clocks, the clock used for the AXI interface and
-- 
1.9.3

Re: [PATCH v3] Documentation: devicetree: Fix ADI AXI SPDIF specification

From: Mark Brown <broonie@kernel.org>
Date: 2014-08-16 21:38:03

On Mon, Jul 28, 2014 at 03:05:03PM +0200, Andreas F?rber wrote:
The specification requires compatible = "adi,axi-spdif-1.00.a" but
driver and example and file name indicate "adi,axi-spdif-tx-1.00.a".
Change the specification to match the implementation.
Applied, let me once again remind you to use commit logs that match the
general style for the subsystem so that it is clear what you are trying
to change and the changelogs look nice.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140816/cd2dd373/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help