Thread (34 messages) 34 messages, 6 authors, 2014-07-25

[PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-07-16 08:41:58
Also in: linux-devicetree, lkml

On Wednesday 16 July 2014 10:26:01 Antoine T?nart wrote:
+
+       if (priv->dma_mask) {
+               ret = dma_coerce_mask_and_coherent(&pdev->dev, priv->dma_mask);
+               if (ret)
+                       return ret;
+       }
+
As mentioned in my comment for the binding, this is the wrong way to do it.
Russell has in the past converted all drivers that did this manually to 
do dma_coerce_mask_and_coherent() so we can spot them more easily, but we
should really be doing this better for new drivers.

Can you describe what the restriction is that you want to put on the dma mask?

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help