From: Russell King <hidden> Date: 2014-06-12 16:09:43
DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
DRM_PANEL && DRM. This is nonsense for two reasons:
(a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
without DRM first being enabled. Hence the && DRM is useless.
(b) These two configs are already beneath a menu which depends on
DRM_PANEL being enabled; these options will not be visible without
DRM_PANEL already being enabled.
Let's just remove this unnecessary verbosity.
Signed-off-by: Russell King <redacted>
---
drivers/gpu/drm/panel/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Andrzej Hajda <hidden> Date: 2014-06-13 05:54:45
Hi Russel,
Thanks for both fixes. Just one nitpick.
On 06/12/2014 06:09 PM, Russell King wrote:
DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
DRM_PANEL && DRM. This is nonsense for two reasons:
(a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
without DRM first being enabled. Hence the && DRM is useless.
This reason is invalid and do not describe the patch anymore.
Regards
Andrzej
quoted hunk
(b) These two configs are already beneath a menu which depends on
DRM_PANEL being enabled; these options will not be visible without
DRM_PANEL already being enabled.
Let's just remove this unnecessary verbosity.
Signed-off-by: Russell King <redacted>
---
drivers/gpu/drm/panel/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Russell King - ARM Linux <hidden> Date: 2014-06-13 13:06:49
On Fri, Jun 13, 2014 at 07:54:45AM +0200, Andrzej Hajda wrote:
Hi Russel,
Thanks for both fixes. Just one nitpick.
On 06/12/2014 06:09 PM, Russell King wrote:
quoted
DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
DRM_PANEL && DRM. This is nonsense for two reasons:
(a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
without DRM first being enabled. Hence the && DRM is useless.
This reason is invalid and do not describe the patch anymore.
Thanks, expect v3 in your mailbox shortly (or already there.)
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.