DORMANTno replies

[PATCH] ARM: drop warning about return_address not using unwind tables

From: Uwe Kleine-König <hidden>
Date: 2014-06-02 09:54:12
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

The warning was introduced in 2009 (commit 4bf1fa5a34aa ([ARM] 5613/1:
implement CALLER_ADDRESSx)). The only result is that CALLER_ADDRESSx for
x > 1 returns NULL which doesn't do much harm.

The drawback of implementing the use of unwind tables for the kernel
tracers is that much of the unwinder code would need to be marked as not
traceable.

Signed-off-by: Uwe Kleine-K?nig <redacted>
---
 arch/arm/kernel/return_address.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c
index fafedd86885d..827d946d2be4 100644
--- a/arch/arm/kernel/return_address.c
+++ b/arch/arm/kernel/return_address.c
@@ -59,10 +59,6 @@ void *return_address(unsigned int level)
 
 #else /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-#if defined(CONFIG_ARM_UNWIND)
-#warning "TODO: return_address should use unwind tables"
-#endif
-
 void *return_address(unsigned int level)
 {
 	return NULL;
-- 
2.0.0.rc2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help