Re: [PATCHv7 2/2] ARM: dts: unuse the slot-node and deprecated supports-highspeed for dw-mmc.

On 13 June 2014 15:31, Jae hoon Chung [off-list ref] wrote:

Hi, Ulf.


2014-06-13 20:14 GMT+09:00 Ulf Hansson [off-list ref]:

quoted

On 13 June 2014 06:31, Jaehoon Chung [off-list ref] wrote:

quoted

dw-mmc controller can support multiple slots.
But, there are no use-cases anywhere. So we don't need to support the
slot-node for dw-mmc controller.
And "supports-highspeed" property in dw-mmc is deprecated.
"supports-highspeed" property can be replaced to "cap-sd/mmc-highspeed".

This looks good to me.

Though, you need to help me understand how to handle this patch.

1) Is it to consider as a fix for 3.16?

Right..It's related with "mmc: dw_mmc: use the mmc_of_parse() instead of
local parser"
DW-MMC didn't parse the subnode, so it didn't set to correct bus-width.

quoted

2 ) I am not sure if there are a dependency to patch 1 - if not this
patch is better suited for ARM SoC.

It's not a dependency on patch 1.
Let me know how i do, plz.

I would suggest you to re-send it to the ARM lits and the ARM SoC guys
and keeping the respective SoC maintainer on the to list of course.

Add a note that it's intended as fix for 3.16 and you may also add my
reviewed by tag.

Kind regards
Uffe

On 06/16/2014 03:56 PM, Ulf Hansson wrote:

On 13 June 2014 15:31, Jae hoon Chung [off-list ref] wrote:

quoted

Hi, Ulf.


2014-06-13 20:14 GMT+09:00 Ulf Hansson [off-list ref]:

quoted

On 13 June 2014 06:31, Jaehoon Chung [off-list ref] wrote:

quoted

dw-mmc controller can support multiple slots.
But, there are no use-cases anywhere. So we don't need to support the
slot-node for dw-mmc controller.
And "supports-highspeed" property in dw-mmc is deprecated.
"supports-highspeed" property can be replaced to "cap-sd/mmc-highspeed".

This looks good to me.

Though, you need to help me understand how to handle this patch.

1) Is it to consider as a fix for 3.16?

Right..It's related with "mmc: dw_mmc: use the mmc_of_parse() instead of
local parser"
DW-MMC didn't parse the subnode, so it didn't set to correct bus-width.

quoted

2 ) I am not sure if there are a dependency to patch 1 - if not this
patch is better suited for ARM SoC.

It's not a dependency on patch 1.
Let me know how i do, plz.

I would suggest you to re-send it to the ARM lits and the ARM SoC guys
and keeping the respective SoC maintainer on the to list of course.

Add a note that it's intended as fix for 3.16 and you may also add my
reviewed by tag.

Ok. I will resend the patch..Thanks

Best Regards,
Jaehoon Chung

Kind regards
Uffe