[PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node

Subsystems: the rest

STALE4470d

2 messages, 2 authors, 2014-06-12 · open the first message on its own page

[PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node

From: Jaewon Kim <hidden>
Date: 2014-06-12 08:23:12

pwm-cells should be 3. Third cell is optional PWM flags.
And This flag supported by this binding is PWM_POLARITY_INVERTED

Signed-off-by: Jaewon Kim <redacted>
---
 arch/arm/boot/dts/exynos4.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..b687e53 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -548,13 +548,13 @@
 		status = "disabled";
 	};
 
-	pwm at 139D0000 {
+	pwm: pwm at 139D0000 {
 		compatible = "samsung,exynos4210-pwm";
 		reg = <0x139D0000 0x1000>;
 		interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
 		clocks = <&clock CLK_PWM>;
 		clock-names = "timers";
-		#pwm-cells = <2>;
+		#pwm-cells = <3>;
 		status = "disabled";
 	};
 
-- 
1.7.9.5

Re: [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node

From: Sachin Kamat <hidden>
Date: 2014-06-12 09:21:42

Hi Jaewon,

On Thu, Jun 12, 2014 at 1:53 PM, Jaewon Kim [off-list ref] wrote:
quoted hunk
pwm-cells should be 3. Third cell is optional PWM flags.
And This flag supported by this binding is PWM_POLARITY_INVERTED

Signed-off-by: Jaewon Kim <redacted>
---
 arch/arm/boot/dts/exynos4.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..b687e53 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -548,13 +548,13 @@
                status = "disabled";
        };

-       pwm at 139D0000 {
+       pwm: pwm at 139D0000 {
unrelated change.
                compatible = "samsung,exynos4210-pwm";
                reg = <0x139D0000 0x1000>;
                interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
                clocks = <&clock CLK_PWM>;
                clock-names = "timers";
-               #pwm-cells = <2>;
+               #pwm-cells = <3>;
                status = "disabled";
        };
Otherwise looks good.
Reviewed-by: Sachin Kamat <redacted>

Regards,
Sachin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help