[PATCH] pinctrl: st: add IRQCHIP_SKIP_SET_WAKE flag

Subsystems: arm/sti architecture, pin control subsystem, the rest

STALE4453d

3 messages, 2 authors, 2014-07-08 · open the first message on its own page

[PATCH] pinctrl: st: add IRQCHIP_SKIP_SET_WAKE flag

From: Patrice CHOTARD <hidden>
Date: 2014-06-25 15:50:05

From: David PARIS <redacted>

no .irq_set_wake API is available for pinctrl-st driver.
Add the IRQCHIP_SKIP_SET_WAKE flag to inform irq handler
not to call this API.

Signed-off-by: David Paris <redacted>
---
 drivers/pinctrl/pinctrl-st.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index fb601fe..d881406 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1530,6 +1530,7 @@ static struct irq_chip st_gpio_irqchip = {
 	.irq_set_type	= st_gpio_irq_set_type,
 	.irq_startup	= st_gpio_irq_startup,
 	.irq_shutdown	= st_gpio_irq_shutdown,
+	.flags		= IRQCHIP_SKIP_SET_WAKE,
 };
 
 static int st_gpio_irq_domain_map(struct irq_domain *h,
-- 
1.9.1

Re: [PATCH] pinctrl: st: add IRQCHIP_SKIP_SET_WAKE flag

From: Linus Walleij <hidden>
Date: 2014-07-07 15:32:26

On Wed, Jun 25, 2014 at 5:49 PM, Patrice CHOTARD [off-list ref] wrote:
From: David PARIS <redacted>

no .irq_set_wake API is available for pinctrl-st driver.
Add the IRQCHIP_SKIP_SET_WAKE flag to inform irq handler
not to call this API.

Signed-off-by: David Paris <redacted>
Patch applied - had to rebase it, strangely the struct is different in
my tree (check that you're in sync).

Yours,
Linus Walleij

Re: [PATCH] pinctrl: st: add IRQCHIP_SKIP_SET_WAKE flag

From: Patrice Chotard <hidden>
Date: 2014-07-08 07:28:33

On 07/07/2014 05:32 PM, Linus Walleij wrote:
On Wed, Jun 25, 2014 at 5:49 PM, Patrice CHOTARD [off-list ref] wrote:
quoted
From: David PARIS <redacted>

no .irq_set_wake API is available for pinctrl-st driver.
Add the IRQCHIP_SKIP_SET_WAKE flag to inform irq handler
not to call this API.

Signed-off-by: David Paris <redacted>
Patch applied - had to rebase it, strangely the struct is different in
my tree (check that you're in sync).
My bad, you are right, i haven't forgotten to rebase on top of your tree.

Sorry Linus

Patrice
Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help