# \[PATCH v8 5/9\] seccomp: split mode set routines

- From: Oleg Nesterov \<oleg@redhat.com\>
- Date: 2014-06-25 13:53:08 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2014/06/4281018
- Thread: https://ratatoskr.run/linux-api/2014/06/4280396/t.md

```text
On 06/24, Kees Cook wrote:
>
> +static inline void seccomp_assign_mode(struct task_struct *task,
> +				       unsigned long seccomp_mode)
> +{
> +	BUG_ON(!spin_is_locked(&task->sighand->siglock));
> +
> +	task->seccomp.mode = seccomp_mode;
> +	set_tsk_thread_flag(task, TIF_SECCOMP);
> +}

OK, but unless task == current this can race with secure_computing().
I think this needs smp_mb__before_atomic() and secure_computing() needs
rmb() after test_bit(TIF_SECCOMP).

Otherwise, can't __secure_computing() hit BUG() if it sees the old
mode == SECCOMP_MODE_DISABLED ?

Or seccomp_run_filters() can see ->filters == NULL and WARN(),
smp_load_acquire() only serializes that LOAD with the subsequent memory
operations.

Oleg.
```
