Thread (21 messages) 21 messages, 3 authors, 2014-05-13
STALE4409d

[PATCH 1/2] hwinit support for non-TI devices

From: Pavel Machek <hidden>
Date: 2014-05-05 13:00:21
Also in: linux-can

quoted
+
+	ctrl = readl(priv->raminit_ctrlreg);
+	ctrl &= ~DCAN_RAM_INIT_BIT;
+	writel(ctrl, priv->raminit_ctrlreg);
Why don't use use the reg directly? Have you read my previous
review?
Not really. I did not notice that there are more comments below all
that quoted text. Standby.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help