From: Rahul Sharma <redacted>
Enable hdmi for exynos5250 based snow board, exynos5420
based peach pit board and 5800 based peach-pi board.
V4:
1) Removed hdmi_hpd_irq pin from peach-pi board as it already
present in exynos5420-pinctrl.dtsi.
V3:
1) Re-spin on dependent patches.
2) Added patch to enable hdmi for Peach-pi board.
V2:
1) Re-spin on dependent patches.
2) Added patch to remove chip specific hdmi hpd gpio from
board file top SoC file.
This series is based on Kukjin Kims, for-next branch.
It is dependent on
1) Sachin's patch: "ARM: dts: exynos5250-snow: add tps65090 power regulator"
at https://patches.linaro.org/28325/ : [Reviewed-by: Doug Anderson]
All other dependent patches are already landed in maintainers
tree.
Rahul Sharma (5):
ARM: dts: enable hdmi for exynos5250 based snow board
ARM: dts: change to correct compatible string for exynos5420 hdmi
ARM: dts: enable hdmi for exynos5420 based peach-pit board
ARM: dts: remove chip specific hdmi hpd pin from board
ARM: dts: enable hdmi for exynos5800 based peach-pi board
arch/arm/boot/dts/exynos5250-cros-common.dtsi | 6 +++++-
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
arch/arm/boot/dts/exynos5250-snow.dts | 7 +++++++
arch/arm/boot/dts/exynos5420-peach-pit.dts | 19 +++++++++++++++++++
arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 ---------
arch/arm/boot/dts/exynos5420.dtsi | 7 ++++++-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 19 +++++++++++++++++++
8 files changed, 70 insertions(+), 11 deletions(-)
--
1.7.9.5
Based on the fact that this is just being configured as input, I don't
think this is a generic special function, but rather a board-specific
GPIO, which should be defined in dts of respective board.
Hmm, those regulators don't seem to be listed in
Documentation/devicetree/bindings/video/exynos_hdmi.txt, at least in
today's linux-next. The driver seems to use them, though.
This isn't a problem with this patch, but if you're working on this,
could you also fix the documentation in separate patch?
Best regards,
Tomasz
Based on the fact that this is just being configured as input, I don't
think this is a generic special function, but rather a board-specific
GPIO, which should be defined in dts of respective board.
Hmm, those regulators don't seem to be listed in
Documentation/devicetree/bindings/video/exynos_hdmi.txt, at least in
today's linux-next. The driver seems to use them, though.
This isn't a problem with this patch, but if you're working on this,
could you also fix the documentation in separate patch?
I will post another patch for documentation update.
Regards,
Rahul Sharma.
From: Rahul Sharma <redacted>
Replace compatible string for HDMI node in Exynos5420. Since
latest restructring in Drm hdmi driver, it is agreed to use
a seperate compatible string for Exynos5420 HDMI IP siince it
uses APB mapped Phy.
Signed-off-by: Rahul Sharma <redacted>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Tomasz Figa <hidden> Date: 2014-05-14 19:44:55
Hi Rahul,
On 14.05.2014 04:45, Rahul Sharma wrote:
quoted hunk
From: Rahul Sharma <redacted>
Replace compatible string for HDMI node in Exynos5420. Since
latest restructring in Drm hdmi driver, it is agreed to use
a seperate compatible string for Exynos5420 HDMI IP siince it
uses APB mapped Phy.
Signed-off-by: Rahul Sharma <redacted>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Tomasz Figa <redacted>
The compatible string doesn't seem to be documented in linux-next,
though. Are the necessary patches adding it already merged?
Best regards,
Tomasz
Hi Rahul,
On 14.05.2014 04:45, Rahul Sharma wrote:
quoted
From: Rahul Sharma <redacted>
Replace compatible string for HDMI node in Exynos5420. Since
latest restructring in Drm hdmi driver, it is agreed to use
a seperate compatible string for Exynos5420 HDMI IP siince it
uses APB mapped Phy.
Signed-off-by: Rahul Sharma <redacted>
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Tomasz Figa <redacted>
The compatible string doesn't seem to be documented in linux-next,
though. Are the necessary patches adding it already merged?
Best regards,
Tomasz
Hmm, this doesn't seem like a proper device node and I don't see other
properties present in exynos5.dtsi either. Are all the necessary patches
already merged in linux-next?
Best regards,
Tomasz
Hmm, this doesn't seem like a proper device node and I don't see other
properties present in exynos5.dtsi either. Are all the necessary patches
already merged in linux-next?
Yea hdmiphy is not a platform driver. It is mapped in hdmi_driver. This code
is already there in driver but documentation is not updated. I can also post
documentation update patch.
Regards,
Rahul Sharma.
From: Rahul Sharma <redacted>
"gpx3-7" is chip specific pin in Exynos5420 for hdmi
hotplug. This pin is moved to exynos5420-pinctrl.dts
and removed from the board file.
Signed-off-by: Rahul Sharma <redacted>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 ---------
1 file changed, 9 deletions(-)
From: Kukjin Kim <hidden> Date: 2014-05-14 18:45:40
On 05/14/14 11:46, Rahul Sharma wrote:
From: Rahul Sharma<redacted>
"gpx3-7" is chip specific pin in Exynos5420 for hdmi
hotplug. This pin is moved to exynos5420-pinctrl.dts
and removed from the board file.
Rahul, you may need to put the change (moving the pin from smdk5420
board to exynos5420-pinctrl.dts) before the patch 3/5.
- Kukjin
On 15 May 2014 00:15, Kukjin Kim [off-list ref] wrote:
On 05/14/14 11:46, Rahul Sharma wrote:
quoted
From: Rahul Sharma<redacted>
"gpx3-7" is chip specific pin in Exynos5420 for hdmi
hotplug. This pin is moved to exynos5420-pinctrl.dts
and removed from the board file.
Rahul, you may need to put the change (moving the pin from smdk5420 board to
exynos5420-pinctrl.dts) before the patch 3/5.
Hi Kukjin,
Ok. I will post with that change tomorrow.
Regards,
Rahul Sharma.
From: Tomasz Figa <hidden> Date: 2014-05-14 19:51:55
Hi Rahul,
On 14.05.2014 04:46, Rahul Sharma wrote:
quoted hunk
From: Rahul Sharma <redacted>
"gpx3-7" is chip specific pin in Exynos5420 for hdmi
hotplug. This pin is moved to exynos5420-pinctrl.dts
and removed from the board file.
Signed-off-by: Rahul Sharma <redacted>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 ---------
1 file changed, 9 deletions(-)
Again, the same comment as for patch 1/5. This pin is being configured
as input, which doesn't look like a dedicated special function pin.
Shouldn't this node rather stay here?
Best regards,
Tomasz
On 15 May 2014 01:21, Tomasz Figa [off-list ref] wrote:
Hi Rahul,
On 14.05.2014 04:46, Rahul Sharma wrote:
quoted
From: Rahul Sharma <redacted>
"gpx3-7" is chip specific pin in Exynos5420 for hdmi
hotplug. This pin is moved to exynos5420-pinctrl.dts
and removed from the board file.
Signed-off-by: Rahul Sharma <redacted>
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 ---------
1 file changed, 9 deletions(-)
Again, the same comment as for patch 1/5. This pin is being configured
as input, which doesn't look like a dedicated special function pin.
Shouldn't this node rather stay here?
What is the 2 flag? I don't see any value other than 0 and 1 defined in
include/dt-bindings/gpio/gpio.h. Also it would be better to use
preprocessor macros instead of magic numbers for flags like this.
Best regards,
Tomasz