[Patch] ARM: dts: keystone: add pll controller syscon entry

Subsystems: the rest

STALE4455d

5 messages, 2 authors, 2014-05-22 · open the first message on its own page

[Patch] ARM: dts: keystone: add pll controller syscon entry

From: Ivan Khoronzhuk <hidden>
Date: 2014-05-21 14:18:35

The pll controller register set includes sets of registers with
different purposes, so it's logically to add syscon entry to be able
to access them from appropriate places.

Signed-off-by: Ivan Khoronzhuk <redacted>
---

Based on linux-next/master

 arch/arm/boot/dts/keystone.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d9f99e7..5e67c5b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -66,6 +66,11 @@
 		ranges = <0x0 0x0 0x0 0xc0000000>;
 		dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
 
+		pllctrl: pll_controller {
+			compatible = "ti,keystone-pllctrl", "syscon";
+			reg = <0x2310000 0x200>;
+		};
+
 		rstctrl: reset-controller {
 			compatible = "ti,keystone-reset";
 			reg = <0x023100e8 4>;	/* pll reset control reg */
-- 
1.8.3.2

Re: [Patch] ARM: dts: keystone: add pll controller syscon entry

From: Ivan Khoronzhuk <hidden>
Date: 2014-05-21 14:57:00

Ignore this. It'll be included in "Introduce keystone reset driver" 
patch series

On 05/21/2014 05:17 PM, Ivan Khoronzhuk wrote:
quoted hunk
The pll controller register set includes sets of registers with
different purposes, so it's logically to add syscon entry to be able
to access them from appropriate places.

Signed-off-by: Ivan Khoronzhuk <redacted>
---

Based on linux-next/master

  arch/arm/boot/dts/keystone.dtsi | 5 +++++
  1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d9f99e7..5e67c5b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -66,6 +66,11 @@
  		ranges = <0x0 0x0 0x0 0xc0000000>;
  		dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
  
+		pllctrl: pll_controller {
+			compatible = "ti,keystone-pllctrl", "syscon";
+			reg = <0x2310000 0x200>;
+		};
+
  		rstctrl: reset-controller {
  			compatible = "ti,keystone-reset";
  			reg = <0x023100e8 4>;	/* pll reset control reg */
-- 
Regards,
Ivan Khoronzhuk

Re: [Patch] ARM: dts: keystone: add pll controller syscon entry

From: Sergei Shtylyov <hidden>
Date: 2014-05-21 18:18:58

Hello.

On 05/21/2014 06:17 PM, Ivan Khoronzhuk wrote:
The pll controller register set includes sets of registers with
different purposes, so it's logically to add syscon entry to be able
to access them from appropriate places.
Signed-off-by: Ivan Khoronzhuk <redacted>
---
Based on linux-next/master
  arch/arm/boot/dts/keystone.dtsi | 5 +++++
  1 file changed, 5 insertions(+)
quoted hunk
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d9f99e7..5e67c5b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -66,6 +66,11 @@
  		ranges = <0x0 0x0 0x0 0xc0000000>;
  		dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;

+		pllctrl: pll_controller {
   I think it's better to follow the pattern established by "reset-controller" 
and use hyphen ISO dash in the node name. This is also a common practice to 
use hyphens in the device trees overall.
+			compatible = "ti,keystone-pllctrl", "syscon";
+			reg = <0x2310000 0x200>;
+		};
+
  		rstctrl: reset-controller {
  			compatible = "ti,keystone-reset";
  			reg = <0x023100e8 4>;	/* pll reset control reg */
WBR, Sergei

Re: [Patch] ARM: dts: keystone: add pll controller syscon entry

From: Sergei Shtylyov <hidden>
Date: 2014-05-21 18:22:48

On 05/21/2014 10:18 PM, Sergei Shtylyov wrote:
quoted
The pll controller register set includes sets of registers with
different purposes, so it's logically to add syscon entry to be able
to access them from appropriate places.
quoted
Signed-off-by: Ivan Khoronzhuk <redacted>
---
quoted
Based on linux-next/master
quoted
  arch/arm/boot/dts/keystone.dtsi | 5 +++++
  1 file changed, 5 insertions(+)
quoted
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
index d9f99e7..5e67c5b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -66,6 +66,11 @@
          ranges = <0x0 0x0 0x0 0xc0000000>;
          dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;

+        pllctrl: pll_controller {
   I think it's better to follow the pattern established by "reset-controller"
and use hyphen ISO dash in the node name. This is also a common practice to
    Oops, hyphen and dash are basically the same thing; I meant 
s/dash/underscore/.
use hyphens in the device trees overall.
quoted
+            compatible = "ti,keystone-pllctrl", "syscon";
+            reg = <0x2310000 0x200>;
+        };
+
          rstctrl: reset-controller {
              compatible = "ti,keystone-reset";
              reg = <0x023100e8 4>;    /* pll reset control reg */
WBR, Sergei

Re: [Patch] ARM: dts: keystone: add pll controller syscon entry

From: Ivan Khoronzhuk <hidden>
Date: 2014-05-22 13:52:01

On 05/21/2014 09:22 PM, Sergei Shtylyov wrote:
On 05/21/2014 10:18 PM, Sergei Shtylyov wrote:
quoted
quoted
The pll controller register set includes sets of registers with
different purposes, so it's logically to add syscon entry to be able
to access them from appropriate places.
quoted
quoted
Signed-off-by: Ivan Khoronzhuk <redacted>
---
quoted
quoted
Based on linux-next/master
quoted
quoted
  arch/arm/boot/dts/keystone.dtsi | 5 +++++
  1 file changed, 5 insertions(+)
quoted
diff --git a/arch/arm/boot/dts/keystone.dtsi 
b/arch/arm/boot/dts/keystone.dtsi
index d9f99e7..5e67c5b 100644
--- a/arch/arm/boot/dts/keystone.dtsi
+++ b/arch/arm/boot/dts/keystone.dtsi
@@ -66,6 +66,11 @@
          ranges = <0x0 0x0 0x0 0xc0000000>;
          dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;

+        pllctrl: pll_controller {
quoted
   I think it's better to follow the pattern established by 
"reset-controller"
and use hyphen ISO dash in the node name. This is also a common 
practice to
   Oops, hyphen and dash are basically the same thing; I meant 
s/dash/underscore/.
You meant s/underscore/dash.
I'll replace.
FYI: the change is included in new series [Patch v5 0/7] Introduce 
keystone reset driver

And this patch is squashed in:
[Patch v5 6/7] ARM: dts: keystone: update reset node to work with reset 
driver

Thanks.
quoted
use hyphens in the device trees overall.
quoted
quoted
+            compatible = "ti,keystone-pllctrl", "syscon";
+            reg = <0x2310000 0x200>;
+        };
+
          rstctrl: reset-controller {
              compatible = "ti,keystone-reset";
              reg = <0x023100e8 4>;    /* pll reset control reg */
WBR, Sergei
-- 
Regards,
Ivan Khoronzhuk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help