From: Suman Anna <hidden> Date: 2014-04-22 22:23:35
Add the mailbox device DT node for OMAP5 SoC. The OMAP5 mailbox
IP is identical to that used in OMAP4.
The OMAP5 hwmod data no longer publishes the module address space,
so this patch fixes the WARN_ON backtrace associated with the
following trace during the kernel boot:
"omap_hwmod: mailbox: doesn't have mpu register target base".
Signed-off-by: Suman Anna <redacted>
---
arch/arm/boot/dts/omap5.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
From: Suman Anna <hidden> Date: 2014-04-22 22:23:36
The mailbox module is capable of generating two interrupts
to MPU in OMAP2420, compared to one in OMAP2430. The second
interrupt is to handle interrupts from the additional IVA
processor present only on OMAP2420.
Move the current common mailbox DT node into the SoC
specific files to allow the above differentiation. Also,
added back the interrupt-names on OMAP2420, that were
previously defined in hwmod data.
Signed-off-by: Suman Anna <redacted>
---
arch/arm/boot/dts/omap2.dtsi | 7 -------
arch/arm/boot/dts/omap2420.dtsi | 8 ++++++++
arch/arm/boot/dts/omap2430.dtsi | 7 +++++++
3 files changed, 15 insertions(+), 7 deletions(-)
From: Suman Anna <hidden> Date: 2014-04-22 22:23:37
AM3517 inherits OMAP3 dts file, but does not have all the IPs
that are present on OMAP3. This patch disables the following
absent IPs for AM3517: Mailbox, IVA, MMU_ISP, MPU_IVA SmartReflex.
A label had to be added for IVA node in omap3.dtsi to be able to
get a reference to the node for disabling.
Signed-off-by: Suman Anna <redacted>
---
arch/arm/boot/dts/am3517.dtsi | 16 ++++++++++++++++
arch/arm/boot/dts/omap3.dtsi | 2 +-
2 files changed, 17 insertions(+), 1 deletion(-)
From: Tony Lindgren <tony@atomide.com> Date: 2014-04-25 16:57:39
* Suman Anna [off-list ref] [140422 15:24]:
Hi Tony, Benoit,
This series includes couple of minor fixes in the OMAP DTS files. The patches
are based on 3.15-rc2.
The first patch fixes the only WARN_ON trace present during kernel boot on
OMAP5 uEVM, and this has been present since some time now.
[ 0.045578] ------------[ cut here ]------------
[ 0.045598] WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2538 _init+0x1c0/0x3dc()
[ 0.045605] omap_hwmod: mailbox: doesn't have mpu register target base
[ 0.045611] Modules linked in:
[ 0.045625] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.15.0-rc2-00001-gb5e85a0 #45
[ 0.045653] [<c0015724>] (unwind_backtrace) from [<c00120f4>] (show_stack+0x10/0x14)
[ 0.045672] [<c00120f4>] (show_stack) from [<c05a1ccc>] (dump_stack+0x78/0x94)
[ 0.045686] [<c05a1ccc>] (dump_stack) from [<c0042a74>] (warn_slowpath_common+0x6c/0x8c)
[ 0.045698] [<c0042a74>] (warn_slowpath_common) from [<c0042b28>] (warn_slowpath_fmt+0x30/0x40)
[ 0.045710] [<c0042b28>] (warn_slowpath_fmt) from [<c0803b40>] (_init+0x1c0/0x3dc)
[ 0.045724] [<c0803b40>] (_init) from [<c0029c8c>] (omap_hwmod_for_each+0x34/0x5c)
[ 0.045736] [<c0029c8c>] (omap_hwmod_for_each) from [<c08042b0>] (__omap_hwmod_setup_all+0x24/0x40)
[ 0.045748] [<c08042b0>] (__omap_hwmod_setup_all) from [<c00088b8>] (do_one_initcall+0x34/0x160)
[ 0.045761] [<c00088b8>] (do_one_initcall) from [<c07f7bf4>] (kernel_init_freeable+0xfc/0x1c8)
[ 0.045772] [<c07f7bf4>] (kernel_init_freeable) from [<c059c4f4>] (kernel_init+0x8/0xe4)
[ 0.045784] [<c059c4f4>] (kernel_init) from [<c000eaa8>] (ret_from_fork+0x14/0x2c)
[ 0.045826] ---[ end trace c25fc521f2569d3c ]---
The last patch eliminates the following traces on AM3517 based boards.
[ 0.418496] platform iva.2: Cannot lookup hwmod 'iva'
[ 0.454352] platform 48094000.mailbox: Cannot lookup hwmod 'mailbox'
[ 0.460610] platform 480bd400.mmu: Cannot lookup hwmod 'mmu_isp'
[ 0.464065] platform 480c9000.smartreflex: Cannot lookup hwmod 'smartreflex_mpu_iva'
There are a few other such traces remaining, but these are all on valid nodes.
[ 0.420275] platform 480c5000.aes: Cannot lookup hwmod 'aes'
[ 0.462403] platform 480c3000.sham: Cannot lookup hwmod 'sham'
[ 0.463246] platform 480cb000.smartreflex: Cannot lookup hwmod 'smartreflex_core'
[ 0.477243] platform 480ab000.usb_otg_hs: Cannot lookup hwmod 'usb_otg_hs'
Thanks applying all three into omap-for-v3.15/fixes-v2 with patch
updated with the above warnings. Next time, please include the
warnings into the patch description, just leave out the time
stamps.
Regards,
Tony
From: Suman Anna <hidden> Date: 2014-04-25 17:14:48
Tony,
On 04/25/2014 11:57 AM, Tony Lindgren wrote:
* Suman Anna [off-list ref] [140422 15:24]:
quoted
Hi Tony, Benoit,
This series includes couple of minor fixes in the OMAP DTS files. The patches
are based on 3.15-rc2.
The first patch fixes the only WARN_ON trace present during kernel boot on
OMAP5 uEVM, and this has been present since some time now.
[ 0.045578] ------------[ cut here ]------------
[ 0.045598] WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2538 _init+0x1c0/0x3dc()
[ 0.045605] omap_hwmod: mailbox: doesn't have mpu register target base
[ 0.045611] Modules linked in:
[ 0.045625] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.15.0-rc2-00001-gb5e85a0 #45
[ 0.045653] [<c0015724>] (unwind_backtrace) from [<c00120f4>] (show_stack+0x10/0x14)
[ 0.045672] [<c00120f4>] (show_stack) from [<c05a1ccc>] (dump_stack+0x78/0x94)
[ 0.045686] [<c05a1ccc>] (dump_stack) from [<c0042a74>] (warn_slowpath_common+0x6c/0x8c)
[ 0.045698] [<c0042a74>] (warn_slowpath_common) from [<c0042b28>] (warn_slowpath_fmt+0x30/0x40)
[ 0.045710] [<c0042b28>] (warn_slowpath_fmt) from [<c0803b40>] (_init+0x1c0/0x3dc)
[ 0.045724] [<c0803b40>] (_init) from [<c0029c8c>] (omap_hwmod_for_each+0x34/0x5c)
[ 0.045736] [<c0029c8c>] (omap_hwmod_for_each) from [<c08042b0>] (__omap_hwmod_setup_all+0x24/0x40)
[ 0.045748] [<c08042b0>] (__omap_hwmod_setup_all) from [<c00088b8>] (do_one_initcall+0x34/0x160)
[ 0.045761] [<c00088b8>] (do_one_initcall) from [<c07f7bf4>] (kernel_init_freeable+0xfc/0x1c8)
[ 0.045772] [<c07f7bf4>] (kernel_init_freeable) from [<c059c4f4>] (kernel_init+0x8/0xe4)
[ 0.045784] [<c059c4f4>] (kernel_init) from [<c000eaa8>] (ret_from_fork+0x14/0x2c)
[ 0.045826] ---[ end trace c25fc521f2569d3c ]---
The last patch eliminates the following traces on AM3517 based boards.
[ 0.418496] platform iva.2: Cannot lookup hwmod 'iva'
[ 0.454352] platform 48094000.mailbox: Cannot lookup hwmod 'mailbox'
[ 0.460610] platform 480bd400.mmu: Cannot lookup hwmod 'mmu_isp'
[ 0.464065] platform 480c9000.smartreflex: Cannot lookup hwmod 'smartreflex_mpu_iva'
There are a few other such traces remaining, but these are all on valid nodes.
[ 0.420275] platform 480c5000.aes: Cannot lookup hwmod 'aes'
[ 0.462403] platform 480c3000.sham: Cannot lookup hwmod 'sham'
[ 0.463246] platform 480cb000.smartreflex: Cannot lookup hwmod 'smartreflex_core'
[ 0.477243] platform 480ab000.usb_otg_hs: Cannot lookup hwmod 'usb_otg_hs'
Thanks applying all three into omap-for-v3.15/fixes-v2 with patch
updated with the above warnings. Next time, please include the
warnings into the patch description, just leave out the time
stamps.
Thanks. I have mentioned the warning for the OMAP5 one very briefly, and
wasn't sure if I needed to copy the entire backtrace, but will remember
to include them in the future.
regards
Suman