# \[PATCH v3 2/5\] mfd: add bcm590xx pmu driver

- From: Matt Porter \<hidden\>
- Date: 2014-03-11 22:19:44 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2014/03/4215929
- Thread: https://ratatoskr.run/linux-devicetree/2014/03/4215712/t.md

```text
On Tue, Mar 11, 2014 at 04:08:37PM +0000, Lee Jones wrote:
> > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > initially supports regmap initialization and instantiation of the
> > voltage regulator device function of the PMU.
> > 
> > Signed-off-by: Matt Porter <redacted>
> > Reviewed-by: Tim Kryger <redacted>
> > Reviewed-by: Markus Mayer <redacted>
> > ---
> >  drivers/mfd/Kconfig          |  8 ++++
> >  drivers/mfd/Makefile         |  1 +
> >  drivers/mfd/bcm590xx.c       | 93 ++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> >  4 files changed, 133 insertions(+)
> >  create mode 100644 drivers/mfd/bcm590xx.c
> >  create mode 100644 include/linux/mfd/bcm590xx.h
> 
> I have a tiny nit that 'ret' doesn't need to be initialised before
> use in probe(), but apart from that...
> 
> Looks pretty sensible:
>   Acked-by: Lee Jones [ref]

Ok, thanks. When I get back in front of my desktop I'll send a v4 of
just this patch to address that nit. Mark already applied the regulator
driver from this series, will you be taking this through your tree? For
that matter, I wonder if the binding would also go through your tree
with this driver.

-Matt
```