Dear Ezequiel Garcia,
On Wed, 22 Jan 2014 20:05:04 -0300, Ezequiel Garcia wrote:
DT-enabled where an irqchip driver for the brigde interrupt controller is
available can handle the watchdog IRQ properly. Therefore, we request
the interruption and add a dummy handler that merely calls panic().
I don't quiite understand the first sentence of this commit log, and
the commit title looks wrong. Maybe a bad copy/paste or something?
This is done in order to have an initial 'ack' of the interruption,
interruption -> interrupt
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
On Sun, Jan 26, 2014 at 09:04:12AM +0100, Thomas Petazzoni wrote:
Dear Ezequiel Garcia,
On Wed, 22 Jan 2014 20:05:04 -0300, Ezequiel Garcia wrote:
quoted
DT-enabled where an irqchip driver for the brigde interrupt controller is
available can handle the watchdog IRQ properly. Therefore, we request
the interruption and add a dummy handler that merely calls panic().
I don't quiite understand the first sentence of this commit log, and
the commit title looks wrong. Maybe a bad copy/paste or something?
Hm... yes it doesn't look right. It should read:
"DT-enabled platforms, where the irqchip driver for the brigde interrupt
controller is available, can handle the watchdog IRQ properly. Therefore,
we request the interrupt and add a dummy handler that merely calls panic()".
I guess we can re-phrase it be a bit more readable.
Why does th commit title looks wrong? By requesting the IRQ we are
"handling it", no?
quoted
This is done in order to have an initial 'ack' of the interruption,
interruption -> interrupt
Right.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
Dear Ezequiel Garcia,
On Sun, 26 Jan 2014 10:14:46 -0300, Ezequiel Garcia wrote:
quoted
I don't quiite understand the first sentence of this commit log, and
the commit title looks wrong. Maybe a bad copy/paste or something?
Hm... yes it doesn't look right. It should read:
"DT-enabled platforms, where the irqchip driver for the brigde interrupt
controller is available, can handle the watchdog IRQ properly. Therefore,
we request the interrupt and add a dummy handler that merely calls panic()".
Ok.
I guess we can re-phrase it be a bit more readable.
Why does th commit title looks wrong? By requesting the IRQ we are
"handling it", no?
Right, but it looks "truncated". Maybe something like:
watchdog: orion: handle irq to avoid having to clear BRIDGE_CLAUSE
or something like that (adjust to the actual reality, I haven't
followed all the implications).
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com