[PATCH v4 12/24] drm/i2c: tda998x: check the CEC device creation

Subsystems: drm drivers, drm drivers and misc gpu patches, the rest

STALE4617d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2014-01-27 · open the first message on its own page

[PATCH v4 12/24] drm/i2c: tda998x: check the CEC device creation

From: Jean-Francois Moine <hidden>
Date: 2014-01-25 17:17:57

This patch checks if the CEC device is well created at intialization
time.

Tested-by: Russell King <redacted>
Signed-off-by: Jean-Francois Moine <redacted>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 1adc794..a3ebc08 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1177,6 +1177,8 @@ tda998x_encoder_init(struct i2c_client *client,
 	priv->current_page = 0xff;
 	priv->hdmi = client;
 	priv->cec = i2c_new_dummy(client->adapter, 0x34);
+	if (!priv->cec)
+		return -ENODEV;
 	priv->dpms = DRM_MODE_DPMS_OFF;
 
 	encoder_slave->slave_priv = priv;
-- 
1.8.5.3

Re: [PATCH v4 12/24] drm/i2c: tda998x: check the CEC device creation

From: Russell King - ARM Linux <hidden>
Date: 2014-01-27 20:01:18

On Sat, Jan 25, 2014 at 06:14:43PM +0100, Jean-Francois Moine wrote:
This patch checks if the CEC device is well created at intialization
time.

Tested-by: Russell King <redacted>
Signed-off-by: Jean-Francois Moine <redacted>
Acked-by: Russell King <redacted>

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help