From: Rongjun Ying <redacted>
When system on the suspend state, Some SoC can't get gpio interrupt.
After system resume, need send extcon uevent to userspace.
Signed-off-by: Rongjun Ying <redacted>
Reviewed-by: Barry Song <redacted>
---
-v3:
'check_on_resume' instead of 'load_sleep_irq' as Chanwoo Choi's proposal.
drivers/extcon/extcon-gpio.c | 20 ++++++++++++++++++++
include/linux/extcon/extcon-gpio.h | 1 +
2 files changed, 21 insertions(+), 0 deletions(-)
@@ -51,6 +51,7 @@ struct gpio_extcon_platform_data {/* if NULL, "0" or "1" will be printed */constchar*state_on;constchar*state_off;+boolcheck_on_resume;};#endif /* __EXTCON_GPIO_H__ */--
This patch has conflict as following:
You have to implement extcon patch based mainline extcon-next branch.
Applying: extcon: gpio: Add power resume support
error: patch failed: drivers/extcon/extcon-gpio.c:103
error: drivers/extcon/extcon-gpio.c: patch does not apply
Patch failed at 0001 extcon: gpio: Add power resume support
The copy of the patch that failed is found in:
/home/cwchoi00/kernel/git.kernel/extcon/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
This time, I will manually apply this patch on extcon branch.
Thanks,
Chanwoo Choi
On 01/07/2014 01:56 PM, RongJun Ying wrote:
quoted hunk
From: Rongjun Ying <redacted>
When system on the suspend state, Some SoC can't get gpio interrupt.
After system resume, need send extcon uevent to userspace.
Signed-off-by: Rongjun Ying <redacted>
Reviewed-by: Barry Song <redacted>
---
-v3:
'check_on_resume' instead of 'load_sleep_irq' as Chanwoo Choi's proposal.
drivers/extcon/extcon-gpio.c | 20 ++++++++++++++++++++
include/linux/extcon/extcon-gpio.h | 1 +
2 files changed, 21 insertions(+), 0 deletions(-)
@@ -51,6 +51,7 @@ struct gpio_extcon_platform_data {/* if NULL, "0" or "1" will be printed */constchar*state_on;constchar*state_off;+boolcheck_on_resume;};#endif /* __EXTCON_GPIO_H__ */--
Hi RongJun,
On 01/07/2014 01:56 PM, RongJun Ying wrote:
quoted hunk
From: Rongjun Ying <redacted>
When system on the suspend state, Some SoC can't get gpio interrupt.
After system resume, need send extcon uevent to userspace.
Signed-off-by: Rongjun Ying <redacted>
Reviewed-by: Barry Song <redacted>
---
-v3:
'check_on_resume' instead of 'load_sleep_irq' as Chanwoo Choi's proposal.
drivers/extcon/extcon-gpio.c | 20 ++++++++++++++++++++
include/linux/extcon/extcon-gpio.h | 1 +
2 files changed, 21 insertions(+), 0 deletions(-)
@@ -103,6 +104,7 @@ static int gpio_extcon_probe(struct platform_device *pdev)extcon_data->gpio_active_low=pdata->gpio_active_low;extcon_data->state_on=pdata->state_on;extcon_data->state_off=pdata->state_off;+extcon_data->check_on_resume=pdata->check_on_resume;if(pdata->state_on&&pdata->state_off)extcon_data->edev.print_state=extcon_gpio_print_state;if(pdata->debounce){
@@ -159,12 +161,30 @@ static int gpio_extcon_remove(struct platform_device *pdev)return0;}+#ifdef CONFIG_PM_SLEEP+staticintgpio_extcon_resume(structdevice*dev)+{+structgpio_extcon_data*extcon_data;++extcon_data=dev_get_drvdata(dev);+if(extcon_data->check_on_resume)+queue_delayed_work(system_power_efficient_wq,+&extcon_data->work,extcon_data->debounce_jiffies);+return0;+}+#endif++staticconststructdev_pm_opsgpio_extcon_pm_ops={+SET_SYSTEM_SLEEP_PM_OPS(NULL,gpio_extcon_resume)
If CONFIG_PM_SLEEP is undefined, gpio_extcon_pm_ops cannot find gpio_extcon_resume function.
You should define dummy function for gpio_extcon_resume function.
-----Original Message-----
From: Chanwoo Choi [mailto:cw00.choi at samsung.com]
Sent: Tuesday, January 07, 2014 2:07 PM
To: RongJun Ying
Cc: MyungJoo Ham; Barry Song; linux-arm-kernel at lists.infradead.org;
linux-kernel at vger.kernel.org; DL-SHA-WorkGroupLinux; Rongjun Ying
Subject: Re: [PATCH v3] extcon: gpio: Add power resume support
This patch has conflict as following:
You have to implement extcon patch based mainline extcon-next branch.
Applying: extcon: gpio: Add power resume support
error: patch failed: drivers/extcon/extcon-gpio.c:103
error: drivers/extcon/extcon-gpio.c: patch does not apply Patch failed
at 0001 extcon: gpio: Add power resume support The copy of the patch
that failed is found in:
/home/cwchoi00/kernel/git.kernel/extcon/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
This time, I will manually apply this patch on extcon branch.
Thanks,
Chanwoo Choi
Thank you.
RongJun Ying
On 01/07/2014 01:56 PM, RongJun Ying wrote:
quoted
From: Rongjun Ying <redacted>
When system on the suspend state, Some SoC can't get gpio interrupt.
After system resume, need send extcon uevent to userspace.
Signed-off-by: Rongjun Ying <redacted>
Reviewed-by: Barry Song <redacted>
---
-v3:
'check_on_resume' instead of 'load_sleep_irq' as Chanwoo Choi's
@@ -51,6 +51,7 @@ struct gpio_extcon_platform_data {/* if NULL, "0" or "1" will be printed */constchar*state_on;constchar*state_off;+boolcheck_on_resume;};#endif /* __EXTCON_GPIO_H__ */--
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Keep up to date with CSR on our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at www.twitter.com/CSR_plc.
New for 2014, you can now access the wide range of products powered by aptX at www.aptx.com.
-----Original Message-----
From: Chanwoo Choi [mailto:cw00.choi at samsung.com]
Sent: Tuesday, January 07, 2014 2:09 PM
To: RongJun Ying
Cc: MyungJoo Ham; Barry Song; linux-arm-kernel at lists.infradead.org;
linux-kernel at vger.kernel.org; DL-SHA-WorkGroupLinux; Rongjun Ying
Subject: Re: [PATCH v3] extcon: gpio: Add power resume support
Hi RongJun,
On 01/07/2014 01:56 PM, RongJun Ying wrote:
quoted
From: Rongjun Ying <redacted>
When system on the suspend state, Some SoC can't get gpio interrupt.
After system resume, need send extcon uevent to userspace.
Signed-off-by: Rongjun Ying <redacted>
Reviewed-by: Barry Song <redacted>
---
-v3:
'check_on_resume' instead of 'load_sleep_irq' as Chanwoo Choi's
If CONFIG_PM_SLEEP is undefined, gpio_extcon_pm_ops cannot find
gpio_extcon_resume function.
You should define dummy function for gpio_extcon_resume function.
In the include/Linux/pm.h
If CONFIG_PM_SLEEP is undefined, the SET_SYSTEM_SLEEP_PM_OPS macro is bypassed.
#ifdef CONFIG_PM_SLEEP
#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
.suspend = suspend_fn, \
.resume = resume_fn, \
.freeze = suspend_fn, \
.thaw = resume_fn, \
.poweroff = suspend_fn, \
.restore = resume_fn,
#else
#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
#endif
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Keep up to date with CSR on our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at www.twitter.com/CSR_plc.
New for 2014, you can now access the wide range of products powered by aptX at www.aptx.com.
Hi Rongjun,
OK, I applied this patch on extcon-next branch.
Thannks,
Chanwoo Choi
On 01/07/2014 06:02 PM, Rongjun Ying wrote:
quoted
-----Original Message-----
From: Chanwoo Choi [mailto:cw00.choi at samsung.com]
Sent: Tuesday, January 07, 2014 2:09 PM
To: RongJun Ying
Cc: MyungJoo Ham; Barry Song; linux-arm-kernel at lists.infradead.org;
linux-kernel at vger.kernel.org; DL-SHA-WorkGroupLinux; Rongjun Ying
Subject: Re: [PATCH v3] extcon: gpio: Add power resume support
Hi RongJun,
On 01/07/2014 01:56 PM, RongJun Ying wrote:
quoted
From: Rongjun Ying <redacted>
When system on the suspend state, Some SoC can't get gpio interrupt.
After system resume, need send extcon uevent to userspace.
Signed-off-by: Rongjun Ying <redacted>
Reviewed-by: Barry Song <redacted>
---
-v3:
'check_on_resume' instead of 'load_sleep_irq' as Chanwoo Choi's
If CONFIG_PM_SLEEP is undefined, gpio_extcon_pm_ops cannot find
gpio_extcon_resume function.
You should define dummy function for gpio_extcon_resume function.
In the include/Linux/pm.h
If CONFIG_PM_SLEEP is undefined, the SET_SYSTEM_SLEEP_PM_OPS macro is bypassed.
#ifdef CONFIG_PM_SLEEP
#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
.suspend = suspend_fn, \
.resume = resume_fn, \
.freeze = suspend_fn, \
.thaw = resume_fn, \
.poweroff = suspend_fn, \
.restore = resume_fn,
#else
#define SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
#endif
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Keep up to date with CSR on our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people, YouTube, www.youtube.com/user/CSRplc, Facebook, www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at www.twitter.com/CSR_plc.
New for 2014, you can now access the wide range of products powered by aptX at www.aptx.com.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/