Thread (34 messages) 34 messages, 8 authors, 2013-12-18
STALE4555d
Revisions (19)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v1 [diff vs current]
  6. v1 [diff vs current]
  7. v1 [diff vs current]
  8. v1 [diff vs current]
  9. v1 [diff vs current]
  10. v1 [diff vs current]
  11. v1 [diff vs current]
  12. v1 [diff vs current]
  13. v1 [diff vs current]
  14. v2 [diff vs current]
  15. v3 [diff vs current]
  16. v3 [diff vs current]
  17. v3 current
  18. v3 [diff vs current]
  19. v5 [diff vs current]

[PATCH v3 0/7] mtd: spi-nor: add a new framework for SPI NOR

From: Huang Shijie <hidden>
Date: 2013-12-17 04:57:54
Also in: linux-spi

On Tue, Dec 17, 2013 at 05:00:53AM +0000, Gupta, Pekon wrote:
quoted
From: Huang Shijie [mailto:b32955 at freescale.com]
On Tue, Dec 17, 2013 at 04:08:33AM +0000, Gupta, Pekon wrote:
quoted
As much base code is copied from m25p90.c,
Do you mind keeping the sign-offs of the original contributors of m25p80.c
at-least in patches where much code is ported ?
I have added the lines in the spi-nor.c:

" Cloned most of the code from the m25p80.c"
quoted
This would at-least give some credit to original authors and contributors.
I do not change any authors information of m25p80.c.

If it is not enough?  Could you remind me what to do ?
(1) Add sign-offs of main authors of m25p80, so that original contributors
 still remains in path of submission [1].
Do you mean add the sign-offs in end of the patch 3's commit message?:
	Signed-off-by: Mike Lavender [off-list ref]

(2) Also, please remove following from spi-nor.c
  However, you can keep this in fsl-quadspi.c.
  +MODULE_AUTHOR("Freescale Semiconductor Inc.");
  I'm sure this was _not_ present in original m25p80.c
 (m25p80.c was started as ST's driver as per MODULE_DESCRIPTION)
okay.
(3)     +MODULE_LICENSE("GPL");
Also, I assume the license version should be "GPLv2" ?
yes. it should be v2.

thanks
Huang Shijie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help