[PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

Subsystems: the rest

STALE4634d

3 messages, 2 authors, 2013-12-02 · open the first message on its own page

[PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

From: Alex Ling <hidden>
Date: 2013-12-01 10:12:31

This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
node. Without this patch, dwmmc host driver will skip enabling the
two clocks and it will break dwmmc host function on exynos4412.
Tested on FriendlyARM TINY4412 board.

Signed-off-by: Alex Ling <redacted>
---
 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e743e67..67bef99 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -67,5 +67,7 @@
 		interrupts = <0 77 0>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		clocks = <&clock 301>, <&clock 149>;
+		clock-names = "biu", "ciu";
 	};
 };
-- 
1.7.9.5

Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

From: Mark Rutland <mark.rutland@arm.com>
Date: 2013-12-02 09:53:46

On Sun, Dec 01, 2013 at 10:11:47AM +0000, Alex Ling wrote:
This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
node. Without this patch, dwmmc host driver will skip enabling the
two clocks and it will break dwmmc host function on exynos4412.
Tested on FriendlyARM TINY4412 board.
The patch description is a little off; this patch adds the clocks as
well as the clock-names.

The patch itself looks fine to me.

Mark.
quoted hunk
Signed-off-by: Alex Ling <redacted>
---
 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e743e67..67bef99 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -67,5 +67,7 @@
 		interrupts = <0 77 0>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		clocks = <&clock 301>, <&clock 149>;
+		clock-names = "biu", "ciu";
 	};
 };
-- 
1.7.9.5

Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

From: Alex Ling <hidden>
Date: 2013-12-02 14:01:45

On Mon, Dec 2, 2013 at 5:52 PM, Mark Rutland [off-list ref] wrote:
On Sun, Dec 01, 2013 at 10:11:47AM +0000, Alex Ling wrote:
quoted
This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
node. Without this patch, dwmmc host driver will skip enabling the
two clocks and it will break dwmmc host function on exynos4412.
Tested on FriendlyARM TINY4412 board.
The patch description is a little off; this patch adds the clocks as
well as the clock-names.
Well noted. I'll update the description later. Thanks!
The patch itself looks fine to me.

Mark.
quoted
Signed-off-by: Alex Ling <redacted>
---
 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e743e67..67bef99 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -67,5 +67,7 @@
              interrupts = <0 77 0>;
              #address-cells = <1>;
              #size-cells = <0>;
+             clocks = <&clock 301>, <&clock 149>;
+             clock-names = "biu", "ciu";
      };
 };
--
1.7.9.5
BR,
Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help