[PATCH v2 02/13] uprobes: allow ignoring of probe hits

[PATCH v2 00/13] uprobes: Add uprobes support for ARM · David Long <hidden> · 2013-10-15
[PATCH v2 01/13] uprobes: move function declarations out of arch · David Long <hidden> · 2013-10-15
Re: [PATCH v2 01/13] uprobes: move function declarations out of arch · Oleg Nesterov <oleg@redhat.com> · 2013-11-05
Re: [PATCH v2 01/13] uprobes: move function declarations out of arch · Oleg Nesterov <oleg@redhat.com> · 2013-11-05
[PATCH] uprobes: Export write_opcode() as uprobe_write_opcode() · Oleg Nesterov <oleg@redhat.com> · 2013-11-05
Re: [PATCH] uprobes: Export write_opcode() as uprobe_write_opcode() · David Long <hidden> · 2013-11-05
Re: [PATCH v2 01/13] uprobes: move function declarations out of arch · David Long <hidden> · 2013-11-05
[PATCH v2 03/13] uprobes: allow arch access to xol slot · David Long <hidden> · 2013-10-15
Re: [PATCH v2 03/13] uprobes: allow arch access to xol slot · Oleg Nesterov <oleg@redhat.com> · 2013-10-19
Re: [PATCH v2 03/13] uprobes: allow arch access to xol slot · David Long <hidden> · 2013-10-23
Re: [PATCH v2 03/13] uprobes: allow arch access to xol slot · Oleg Nesterov <oleg@redhat.com> · 2013-10-29
[PATCH] uprobes: introduce arch_uprobe->ixol · Oleg Nesterov <oleg@redhat.com> · 2013-11-04
Re: [PATCH] uprobes: introduce arch_uprobe->ixol · David Long <hidden> · 2013-11-04
Re: [PATCH] uprobes: introduce arch_uprobe->ixol · David Long <hidden> · 2013-11-05
Re: [PATCH] uprobes: introduce arch_uprobe->ixol · Oleg Nesterov <oleg@redhat.com> · 2013-11-05
Re: [PATCH] uprobes: introduce arch_uprobe->ixol · David Long <hidden> · 2013-11-05
[PATCH v2 05/13] uprobes: add arch write opcode hook · David Long <hidden> · 2013-10-15
Re: [PATCH v2 05/13] uprobes: add arch write opcode hook · Oleg Nesterov <oleg@redhat.com> · 2013-10-19
Re: [PATCH v2 05/13] uprobes: add arch write opcode hook · David Long <hidden> · 2013-10-23
Re: [PATCH v2 05/13] uprobes: add arch write opcode hook · Oleg Nesterov <oleg@redhat.com> · 2013-10-28
Re: [PATCH v2 05/13] uprobes: add arch write opcode hook · Oleg Nesterov <oleg@redhat.com> · 2013-10-29
Re: [PATCH v2 05/13] uprobes: add arch write opcode hook · David Long <hidden> · 2013-11-02
Re: [PATCH v2 05/13] uprobes: add arch write opcode hook · Oleg Nesterov <oleg@redhat.com> · 2013-11-02
[PATCH v2 06/13] ARM: move shared uprobe/kprobe definitions into new include file · David Long <hidden> · 2013-10-15
[PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · David Long <hidden> · 2013-10-15
Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · Jon Medhurst (Tixy) <hidden> · 2013-11-13
Re: Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · Masami Hiramatsu <hidden> · 2013-11-14
Re: Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · Jon Medhurst (Tixy) <hidden> · 2013-11-14
Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · David Long <hidden> · 2013-11-14
Re: Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · Masami Hiramatsu <hidden> · 2013-11-15
Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · David Long <hidden> · 2013-11-15
Re: Re: Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · Masami Hiramatsu <hidden> · 2013-11-15
Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn · Masami Hiramatsu <hidden> · 2013-11-14
[PATCH v2 09/13] ARM: Disable jprobe selftests in thumb kernels · David Long <hidden> · 2013-10-15
Re: [PATCH v2 09/13] ARM: Disable jprobe selftests in thumb kernels · Jon Medhurst (Tixy) <hidden> · 2013-11-07
Re: [PATCH v2 09/13] ARM: Disable jprobe selftests in thumb kernels · David Long <hidden> · 2013-11-10
[PATCH v2 11/13] ARM: Finish renaming ARM kprobes APIs for sharing with uprobes · David Long <hidden> · 2013-10-15
Re: [PATCH v2 11/13] ARM: Finish renaming ARM kprobes APIs for sharing with uprobes · Jon Medhurst (Tixy) <hidden> · 2013-11-13
Re: [PATCH v2 11/13] ARM: Finish renaming ARM kprobes APIs for sharing with uprobes · David Long <hidden> · 2013-11-15
[PATCH v2 13/13] ARM: Remove uprobes dependency on kprobes · David Long <hidden> · 2013-10-15
[PATCH v2 12/13] ARM: add uprobes support · David Long <hidden> · 2013-10-15
[PATCH v2 04/13] uprobes: allow arch-specific initialization · David Long <hidden> · 2013-10-15
Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization · Oleg Nesterov <oleg@redhat.com> · 2013-10-19
Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization · David Long <hidden> · 2013-10-23
Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization · Oleg Nesterov <oleg@redhat.com> · 2013-10-28
Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization · David Long <hidden> · 2013-10-31
Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization · Oleg Nesterov <oleg@redhat.com> · 2013-11-01
Re: [PATCH v2 04/13] uprobes: allow arch-specific initialization · David Long <hidden> · 2013-11-04
[PATCH v2 02/13] uprobes: allow ignoring of probe hits · David Long <hidden> · 2013-10-15
Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits · Oleg Nesterov <oleg@redhat.com> · 2013-10-19
Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits · David Long <hidden> · 2013-10-22
Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits · Oleg Nesterov <hidden> · 2013-10-22
Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits · David Long <hidden> · 2013-10-22
Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits · Oleg Nesterov <oleg@redhat.com> · 2013-10-28
Re: [PATCH v2 02/13] uprobes: allow ignoring of probe hits · David Long <hidden> · 2013-10-30

From: oleg@redhat.com (Oleg Nesterov)
Date: 2013-10-19 17:09:25
Also in: lkml

On 10/15, David Long wrote:

quoted hunk ↗ jump to hunk

@@ -1732,9 +1732,6 @@ static void handle_swbp(struct pt_regs *regs)
 		return;
 	}
 
-	/* change it in advance for ->handler() and restart */
-	instruction_pointer_set(regs, bp_vaddr);
-

Well, this looks obviously wrong. This SET_IP() has the comment ;)

Note also that with this breaks __skip_sstep() on x86.

Oleg.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help