Thread (40 messages) 40 messages, 4 authors, 2013-07-09

[RFC PATCH 6/6] ARM: OMAP3: Enable Hardware Save and Restore for USB Host

From: Sergei Shtylyov <hidden>
Date: 2013-06-19 17:30:03
Also in: linux-omap, lkml

Hello.

On 06/19/2013 06:05 PM, Roger Quadros wrote:
To ensure hardware context is restored while resuming from
OFF mode we need to enable the Hardware SAR bit for the
USB Host power domain.
Signed-off-by: Roger Quadros <redacted>
---
  arch/arm/mach-omap2/powerdomains3xxx_data.c |    8 +-------
  1 files changed, 1 insertions(+), 7 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c b/arch/arm/mach-omap2/powerdomains3xxx_data.c
index f0e14e9..9554d2b 100644
--- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
@@ -289,13 +289,7 @@ static struct powerdomain usbhost_pwrdm = {
  	.prcm_offs	  = OMAP3430ES2_USBHOST_MOD,
  	.pwrsts		  = PWRSTS_OFF_RET_ON,
  	.pwrsts_logic_ret = PWRSTS_RET,
-	/*
-	 * REVISIT: Enabling usb host save and restore mechanism seems to
-	 * leave the usb host domain permanently in ACTIVE mode after
-	 * changing the usb host power domain state from OFF to active once.
-	 * Disabling for now.
-	 */
-	/*.flags	  = PWRDM_HAS_HDWR_SAR,*/ /* for USBHOST ctrlr only */
+	.flags	  = PWRDM_HAS_HDWR_SAR, /* for USBHOST ctrlr only */
    Looks like you're not indenting = right, in accordance to the other 
fields...
  	.banks		  = 1,
  	.pwrsts_mem_ret	  = {
  		[0] = PWRSTS_RET, /* MEMRETSTATE */
WBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help