[PATCH] ARM: tegra: fix ignored return value of regulator_enable

Subsystems: arm port, the rest

STALE4900d

2 messages, 1 author, 2013-03-07 · open the first message on its own page

[PATCH] ARM: tegra: fix ignored return value of regulator_enable

From: Stephen Warren <hidden>
Date: 2013-03-07 00:16:25

From: Stephen Warren <redacted>

This fixes:

arch/arm/mach-tegra/board-harmony-pcie.c: In function ?harmony_pcie_init?:
arch/arm/mach-tegra/board-harmony-pcie.c:65:18: warning: ignoring return
    value of ?regulator_enable?, declared with attribute
    warn_unused_result [-Wunused-result]

Signed-off-by: Stephen Warren <redacted>
---
 arch/arm/mach-tegra/board-harmony-pcie.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/board-harmony-pcie.c b/arch/arm/mach-tegra/board-harmony-pcie.c
index 3cdc1bb..d195db0 100644
--- a/arch/arm/mach-tegra/board-harmony-pcie.c
+++ b/arch/arm/mach-tegra/board-harmony-pcie.c
@@ -62,7 +62,11 @@ int __init harmony_pcie_init(void)
 		goto err_reg;
 	}
 
-	regulator_enable(regulator);
+	err = regulator_enable(regulator);
+	if (err) {
+		pr_err("%s: regulator_enable failed: %d\n", __func__, err);
+		goto err_en;
+	}
 
 	err = tegra_pcie_init(true, true);
 	if (err) {
@@ -74,6 +78,7 @@ int __init harmony_pcie_init(void)
 
 err_pcie:
 	regulator_disable(regulator);
+err_en:
 	regulator_put(regulator);
 err_reg:
 	gpio_free(en_vdd_1v05);
-- 
1.7.10.4

[PATCH] ARM: tegra: fix ignored return value of regulator_enable

From: Stephen Warren <hidden>
Date: 2013-03-07 20:31:40

On 03/06/2013 05:16 PM, Stephen Warren wrote:
This fixes:

arch/arm/mach-tegra/board-harmony-pcie.c: In function ?harmony_pcie_init?:
arch/arm/mach-tegra/board-harmony-pcie.c:65:18: warning: ignoring return
    value of ?regulator_enable?, declared with attribute
    warn_unused_result [-Wunused-result]
I've applied this to Tegra's for-3.10/fixes branch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help