[PATCH] ARM: OMAP4: PRM: Correct reset source map

Subsystems: arm port, omap powerdomain soc adaptation layer support, omap2+ support, the rest

STALE4979d

6 messages, 2 authors, 2012-12-19 · open the first message on its own page

[PATCH] ARM: OMAP4: PRM: Correct reset source map

From: Ivan Khoronzhuk <hidden>
Date: 2012-12-19 10:07:10

In the map for reset sources register we use defines intended for
using with PRM_RSTCTRL register. So fix it.

Signed-off-by: Ivan Khoronzhuk <redacted>
---
 arch/arm/mach-omap2/prm44xx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
index 7498bc7..e335216 100644
--- a/arch/arm/mach-omap2/prm44xx.c
+++ b/arch/arm/mach-omap2/prm44xx.c
@@ -56,9 +56,9 @@ static struct omap_prcm_irq_setup omap4_prcm_irq_setup = {
  *   enumeration)
  */
 static struct prm_reset_src_map omap44xx_prm_reset_src_map[] = {
-	{ OMAP4430_RST_GLOBAL_WARM_SW_SHIFT,
+	{ OMAP4430_GLOBAL_WARM_SW_RST_SHIFT,
 	  OMAP_GLOBAL_WARM_RST_SRC_ID_SHIFT },
-	{ OMAP4430_RST_GLOBAL_COLD_SW_SHIFT,
+	{ OMAP4430_GLOBAL_COLD_RST_SHIFT,
 	  OMAP_GLOBAL_COLD_RST_SRC_ID_SHIFT },
 	{ OMAP4430_MPU_SECURITY_VIOL_RST_SHIFT,
 	  OMAP_SECU_VIOL_RST_SRC_ID_SHIFT },
-- 
1.7.9.5

[PATCH] ARM: OMAP4: PRM: Correct wrong instance usage for reading reset sources

From: Ivan Khoronzhuk <hidden>
Date: 2012-12-19 10:07:20

To read reset sources registers we have to use PRM_DEVICE_INST

Signed-off-by: Ivan Khoronzhuk <redacted>
---
 arch/arm/mach-omap2/prm44xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
index 7498bc7..0b61b8d 100644
--- a/arch/arm/mach-omap2/prm44xx.c
+++ b/arch/arm/mach-omap2/prm44xx.c
@@ -333,7 +333,7 @@ static u32 omap44xx_prm_read_reset_sources(void)
 	u32 r = 0;
 	u32 v;
 
-	v = omap4_prm_read_inst_reg(OMAP4430_PRM_OCP_SOCKET_INST,
+	v = omap4_prm_read_inst_reg(OMAP4430_PRM_DEVICE_INST,
 				    OMAP4_RM_RSTST);
 
 	p = omap44xx_prm_reset_src_map;
-- 
1.7.9.5

[PATCH] ARM: OMAP4: PRM: fix RSTTIME and RSTST offsets

From: Ivan Khoronzhuk <hidden>
Date: 2012-12-19 10:07:26

From: Nishanth Menon <nm@ti.com>

RSTTIME is offset 0x8 and RSTST is offset 0x04 for OMAP4430 and
OMAP4460.

Signed-off-by: Nishanth Menon <nm@ti.com>
[ivan.khoronzhuk at ti.com: ported from k3.4]
Signed-off-by: Ivan Khoronzhuk <redacted>
---
 arch/arm/mach-omap2/prm44xx.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/prm44xx.h b/arch/arm/mach-omap2/prm44xx.h
index 22b0979..8ee1fbd 100644
--- a/arch/arm/mach-omap2/prm44xx.h
+++ b/arch/arm/mach-omap2/prm44xx.h
@@ -62,8 +62,8 @@
 
 /* OMAP4 specific register offsets */
 #define OMAP4_RM_RSTCTRL				0x0000
-#define OMAP4_RM_RSTTIME				0x0004
-#define OMAP4_RM_RSTST					0x0008
+#define OMAP4_RM_RSTST					0x0004
+#define OMAP4_RM_RSTTIME				0x0008
 #define OMAP4_PM_PWSTCTRL				0x0000
 #define OMAP4_PM_PWSTST					0x0004
 
-- 
1.7.9.5

Re: [PATCH] ARM: OMAP4: PRM: Correct reset source map

From: Paul Walmsley <paul@pwsan.com>
Date: 2012-12-19 16:57:18

On Wed, 19 Dec 2012, Ivan Khoronzhuk wrote:
In the map for reset sources register we use defines intended for
using with PRM_RSTCTRL register. So fix it.

Signed-off-by: Ivan Khoronzhuk <redacted>
Thanks, queued for v3.8-rc fixes.


- Paul

Re: [PATCH] ARM: OMAP4: PRM: fix RSTTIME and RSTST offsets

From: Paul Walmsley <paul@pwsan.com>
Date: 2012-12-19 16:57:33

On Wed, 19 Dec 2012, Ivan Khoronzhuk wrote:
From: Nishanth Menon <nm@ti.com>

RSTTIME is offset 0x8 and RSTST is offset 0x04 for OMAP4430 and
OMAP4460.

Signed-off-by: Nishanth Menon <nm@ti.com>
[ivan.khoronzhuk at ti.com: ported from k3.4]
Signed-off-by: Ivan Khoronzhuk <redacted>
Thanks guys, queued for v3.8-rc fixes.

- Paul

Re: [PATCH] ARM: OMAP4: PRM: Correct wrong instance usage for reading reset sources

From: Paul Walmsley <paul@pwsan.com>
Date: 2012-12-19 16:57:44

On Wed, 19 Dec 2012, Ivan Khoronzhuk wrote:
To read reset sources registers we have to use PRM_DEVICE_INST

Signed-off-by: Ivan Khoronzhuk <redacted>
Thanks, queued for v3.8-rc fixes.


- Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help