[PATCH 1/2] ARM: OMAP3: PRCM: Fix incorrect read of reset sources

Subsystems: arm port, omap2+ support, the rest

STALE4980d

4 messages, 2 authors, 2012-12-17 · open the first message on its own page

[PATCH 1/2] ARM: OMAP3: PRCM: Fix incorrect read of reset sources

From: Ivan Khoronzhuk <hidden>
Date: 2012-12-17 17:28:02

The flag mask are incorrect, so fix it.

Signed-off-by: Ivan Khoronzhuk <redacted>
---
 arch/arm/mach-omap2/prcm.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/prcm.c b/arch/arm/mach-omap2/prcm.c
index 0f51e03..dc45156 100644
--- a/arch/arm/mach-omap2/prcm.c
+++ b/arch/arm/mach-omap2/prcm.c
@@ -48,9 +48,10 @@ void __iomem *prcm_mpu_base;
 
 u32 omap_prcm_get_reset_sources(void)
 {
-	/* XXX This presumably needs modification for 34XX */
-	if (cpu_is_omap24xx() || cpu_is_omap34xx())
+	if (cpu_is_omap24xx())
 		return omap2_prm_read_mod_reg(WKUP_MOD, OMAP2_RM_RSTST) & 0x7f;
+	if (cpu_is_omap34xx())
+		return omap2_prm_read_mod_reg(WKUP_MOD, OMAP2_RM_RSTST) & 0x7ff;
 	if (cpu_is_omap44xx())
 		return omap2_prm_read_mod_reg(WKUP_MOD, OMAP4_RM_RSTST) & 0x7f;
 
-- 
1.7.9.5

[PATCH 2/2] ARM: OMAP4: PRCM: Fix incorrect read of reset sources

From: Ivan Khoronzhuk <hidden>
Date: 2012-12-17 17:28:07

The address of PRM_RSTST register and flag mask are incorrect,
so fix it.

Signed-off-by: Ivan Khoronzhuk <redacted>
---
 arch/arm/mach-omap2/prcm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/prcm.c b/arch/arm/mach-omap2/prcm.c
index dc45156..02f27f2 100644
--- a/arch/arm/mach-omap2/prcm.c
+++ b/arch/arm/mach-omap2/prcm.c
@@ -53,8 +53,8 @@ u32 omap_prcm_get_reset_sources(void)
 	if (cpu_is_omap34xx())
 		return omap2_prm_read_mod_reg(WKUP_MOD, OMAP2_RM_RSTST) & 0x7ff;
 	if (cpu_is_omap44xx())
-		return omap2_prm_read_mod_reg(WKUP_MOD, OMAP4_RM_RSTST) & 0x7f;
-
+		return omap4_prm_read_inst_reg(OMAP4430_PRM_DEVICE_INST,
+					       OMAP4_PRM_RSTST_OFFSET) & 0x7ff;
 	return 0;
 }
 EXPORT_SYMBOL(omap_prcm_get_reset_sources);
-- 
1.7.9.5

Re: [PATCH 1/2] ARM: OMAP3: PRCM: Fix incorrect read of reset sources

From: Paul Walmsley <paul@pwsan.com>
Date: 2012-12-17 18:24:23

Hi

On Mon, 17 Dec 2012, Ivan Khoronzhuk wrote:
The flag mask are incorrect, so fix it.

Signed-off-by: Ivan Khoronzhuk <redacted>
arch/arm/mach-omap2/prcm.c no longer exists in current mainline; please 
rebase this against Linus' current tree.


- Paul

Re: [PATCH 2/2] ARM: OMAP4: PRCM: Fix incorrect read of reset sources

From: Paul Walmsley <paul@pwsan.com>
Date: 2012-12-17 18:24:38

Hi

On Mon, 17 Dec 2012, Ivan Khoronzhuk wrote:
The address of PRM_RSTST register and flag mask are incorrect,
so fix it.

Signed-off-by: Ivan Khoronzhuk <redacted>
arch/arm/mach-omap2/prcm.c no longer exists in current mainline; please
rebase this against Linus' current tree.


- Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help