Chao Xie [off-list ref] writes:
Hi Chao Xie,
First of all, could you please send patches from rtc-pxa to me also, as I'm
maintaining that driver ?
Second point, the original design of the driver relies on the special case of
writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter
21.4.2.3.5 "Writing Alarm Registers with Invalid (Zero) Data", which states :
Day-Of-Week (DOW), or Week-Of-Month (WOM), Day of Month (DOM), Month or Year
fields?Zero is not valid for these fields. If zero is written into any of
these fields, it is ignored while generating the alarm.
I'd like to know if your patch fixes something, or is an enhancement ?
Cheers.
--
Robert
PS: I've not checked the patch yet, that's just a prelimary comment on the patch
message.
On Fri, Nov 30, 2012 at 4:04 AM, Robert Jarzmik [off-list ref] wrote:
Chao Xie [off-list ref] writes:
Hi Chao Xie,
First of all, could you please send patches from rtc-pxa to me also, as I'm
maintaining that driver ?
Second point, the original design of the driver relies on the special case of
writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter
21.4.2.3.5 "Writing Alarm Registers with Invalid (Zero) Data", which states :
quoted
Day-Of-Week (DOW), or Week-Of-Month (WOM), Day of Month (DOM), Month or Year
fields?Zero is not valid for these fields. If zero is written into any of
these fields, it is ignored while generating the alarm.
I'd like to know if your patch fixes something, or is an enhancement ?
Cheers.
--
Robert
PS: I've not checked the patch yet, that's just a prelimary comment on the patch
message.
hi
I am sorry, i just use get_maintainer.pl to get the "to" list.
I have go through the spec. The spec has the desctiption about the
invalid data writing.
I am a little confused about the "wrting 0 to DOW". The descrption is
confused. first it said that "If zero is written into any of these
fields, it is ignored
while generating the alarm", then it gives a example, that if writing
0 to DOW, "For example, if a zero is written into a DOW field, the
alarm is set
every day at the time written in the Hours, Minutes, and Seconds
field?. It seems that the Year/Month/Week will not take effect.
I will do the test on the board again, and send out the update.
On Mon, Dec 3, 2012 at 10:40 AM, Chao Xie [off-list ref] wrote:
On Fri, Nov 30, 2012 at 4:04 AM, Robert Jarzmik [off-list ref] wrote:
quoted
Chao Xie [off-list ref] writes:
Hi Chao Xie,
First of all, could you please send patches from rtc-pxa to me also, as I'm
maintaining that driver ?
Second point, the original design of the driver relies on the special case of
writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter
21.4.2.3.5 "Writing Alarm Registers with Invalid (Zero) Data", which states :
quoted
Day-Of-Week (DOW), or Week-Of-Month (WOM), Day of Month (DOM), Month or Year
fields?Zero is not valid for these fields. If zero is written into any of
these fields, it is ignored while generating the alarm.
I'd like to know if your patch fixes something, or is an enhancement ?
Cheers.
--
Robert
PS: I've not checked the patch yet, that's just a prelimary comment on the patch
message.
hi
I am sorry, i just use get_maintainer.pl to get the "to" list.
I have go through the spec. The spec has the desctiption about the
invalid data writing.
I am a little confused about the "wrting 0 to DOW". The descrption is
confused. first it said that "If zero is written into any of these
fields, it is ignored
while generating the alarm", then it gives a example, that if writing
0 to DOW, "For example, if a zero is written into a DOW field, the
alarm is set
every day at the time written in the Hours, Minutes, and Seconds
field?. It seems that the Year/Month/Week will not take effect.
I will do the test on the board again, and send out the update.
hi, Robert
You are right. it does not matter to set WOM and DOW. please ignore this patch.