[PATCH] ARM: highbank: retry wfi on reset request

Subsystems: arm port, arm/calxeda highbank architecture, the rest

STALE5025d

3 messages, 2 authors, 2012-11-06 · open the first message on its own page

[PATCH] ARM: highbank: retry wfi on reset request

From: Rob Herring <hidden>
Date: 2012-10-26 03:20:37

From: Rob Herring <redacted>

In some cases, an interrupt can occur and prevent cause failure to enter
wfi. This causes reset to hang. Retrying the wfi should be enough to
prevent reset from hanging.

Signed-off-by: Rob Herring <redacted>
---
 arch/arm/mach-highbank/system.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-highbank/system.c b/arch/arm/mach-highbank/system.c
index 82c2723..86e37cd 100644
--- a/arch/arm/mach-highbank/system.c
+++ b/arch/arm/mach-highbank/system.c
@@ -28,6 +28,7 @@ void highbank_restart(char mode, const char *cmd)
 		hignbank_set_pwr_soft_reset();
 
 	scu_power_mode(scu_base_addr, SCU_PM_POWEROFF);
-	cpu_do_idle();
+	while (1)
+		cpu_do_idle();
 }
 
-- 
1.7.10.4

[PATCH] ARM: highbank: retry wfi on reset request

From: Rob Herring <hidden>
Date: 2012-10-29 17:22:56

On 10/25/2012 10:20 PM, Rob Herring wrote:
From: Rob Herring <redacted>

In some cases, an interrupt can occur and prevent cause failure to enter
wfi. This causes reset to hang. Retrying the wfi should be enough to
prevent reset from hanging.

Signed-off-by: Rob Herring <redacted>
---
Arnd, Olof,

Can you please apply this for 3.7?

Rob
quoted hunk
 arch/arm/mach-highbank/system.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-highbank/system.c b/arch/arm/mach-highbank/system.c
index 82c2723..86e37cd 100644
--- a/arch/arm/mach-highbank/system.c
+++ b/arch/arm/mach-highbank/system.c
@@ -28,6 +28,7 @@ void highbank_restart(char mode, const char *cmd)
 		hignbank_set_pwr_soft_reset();
 
 	scu_power_mode(scu_base_addr, SCU_PM_POWEROFF);
-	cpu_do_idle();
+	while (1)
+		cpu_do_idle();
 }
 

[PATCH] ARM: highbank: retry wfi on reset request

From: Olof Johansson <hidden>
Date: 2012-11-06 14:55:22

On Thu, Oct 25, 2012 at 10:20:37PM -0500, Rob Herring wrote:
From: Rob Herring <redacted>

In some cases, an interrupt can occur and prevent cause failure to enter
wfi. This causes reset to hang. Retrying the wfi should be enough to
prevent reset from hanging.

Signed-off-by: Rob Herring <redacted>
Applied, thanks.


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help