[PATCH v3 0/4] ARM: dts: Update OMAP5 with address space and interrupts

STALE5066d

Revision v3 of 2 in this series.

8 messages, 2 authors, 2012-10-24 · open the first message on its own page

[PATCH v3 0/4] ARM: dts: Update OMAP5 with address space and interrupts

From: Sebastien Guiriec <hidden>
Date: 2012-10-24 07:07:29

Since kernel 3.7 the DTS data are not overwriten by hwmod data we can add the address space
and interrupt line description inside dtsi file for OMAP5. This serie is updating the
current OMAP5 IP with missing entry.

It has been tested on OMAP5 with 3.7-audio-display feature tree.
- MMC is probing and functional
- TWL6041 probing (GPIO/I2C)
- booting (UART)

Update since v1:
- Add Ack and review
- Fix up commit messages.

Update since v2:
- Add interrupt-parent.

Sebastien Guiriec (4):
  ARM: dts: omap5: Update GPIO with address space and interrupts
  ARM: dts: omap5: Update I2C with address space and interrupts
  ARM: dts: omap5: Update UART with address space and interrupts
  ARM: dts: omap5: Update MMC with address space and interrupts

 arch/arm/boot/dts/omap5.dtsi |   80 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 76 insertions(+), 4 deletions(-)

-- 
1.7.10.4

[PATCH v3 3/4] ARM: dts: omap5: Update UART with address space and interrupts

From: Sebastien Guiriec <hidden>
Date: 2012-10-24 07:07:33

Add base address and interrupt line inside Device Tree data for
OMAP5.

Signed-off-by: Sebastien Guiriec <redacted>
Reviewed-by: Shubhrajyoti D <redacted>
---
 arch/arm/boot/dts/omap5.dtsi |   22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 07d2607..b535d8e 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi

@@ -250,36 +250,54 @@
 
 		uart1: serial at 4806a000 {
 			compatible = "ti,omap4-uart";
+			reg = <0x4806a000 0x100>;
+			interrupts = <0 72 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "uart1";
 			clock-frequency = <48000000>;
 		};
 
 		uart2: serial at 4806c000 {
 			compatible = "ti,omap4-uart";
+			reg = <0x4806c000 0x100>;
+			interrupts = <0 73 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "uart2";
 			clock-frequency = <48000000>;
 		};
 
 		uart3: serial at 48020000 {
 			compatible = "ti,omap4-uart";
+			reg = <0x48020000 0x100>;
+			interrupts = <0 74 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "uart3";
 			clock-frequency = <48000000>;
 		};
 
 		uart4: serial at 4806e000 {
 			compatible = "ti,omap4-uart";
+			reg = <0x4806e000 0x100>;
+			interrupts = <0 70 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "uart4";
 			clock-frequency = <48000000>;
 		};
 
 		uart5: serial at 48066000 {
-			compatible = "ti,omap5-uart";
+			compatible = "ti,omap4-uart";
+			reg = <0x48066000 0x100>;
+			interrupts = <0 105 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "uart5";
 			clock-frequency = <48000000>;
 		};
 
 		uart6: serial at 48068000 {
-			compatible = "ti,omap6-uart";
+			compatible = "ti,omap4-uart";
+			reg = <0x48068000 0x100>;
+			interrupts = <0 106 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "uart6";
 			clock-frequency = <48000000>;
 		};

-- 
1.7.10.4

[PATCH v3 4/4] ARM: dts: omap5: Update MMC with address space and interrupts

From: Sebastien Guiriec <hidden>
Date: 2012-10-24 07:07:43

Add base address and interrupt line inside Device Tree data for
OMAP5.

Signed-off-by: Sebastien Guiriec <redacted>
---
 arch/arm/boot/dts/omap5.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index b535d8e..304dd8d 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi

@@ -304,6 +304,9 @@
 
 		mmc1: mmc at 4809c000 {
 			compatible = "ti,omap4-hsmmc";
+			reg = <0x4809c000 0x400>;
+			interrupts = <0 83 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "mmc1";
 			ti,dual-volt;
 			ti,needs-special-reset;

@@ -311,24 +314,36 @@
 
 		mmc2: mmc at 480b4000 {
 			compatible = "ti,omap4-hsmmc";
+			reg = <0x480b4000 0x400>;
+			interrupts = <0 86 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "mmc2";
 			ti,needs-special-reset;
 		};
 
 		mmc3: mmc at 480ad000 {
 			compatible = "ti,omap4-hsmmc";
+			reg = <0x480ad000 0x400>;
+			interrupts = <0 94 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "mmc3";
 			ti,needs-special-reset;
 		};
 
 		mmc4: mmc at 480d1000 {
 			compatible = "ti,omap4-hsmmc";
+			reg = <0x480d1000 0x400>;
+			interrupts = <0 96 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "mmc4";
 			ti,needs-special-reset;
 		};
 
 		mmc5: mmc at 480d5000 {
 			compatible = "ti,omap4-hsmmc";
+			reg = <0x480d5000 0x400>;
+			interrupts = <0 59 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "mmc5";
 			ti,needs-special-reset;
 		};

-- 
1.7.10.4

[PATCH v3 2/4] ARM: dts: omap5: Update I2C with address space and interrupts

From: Sebastien Guiriec <hidden>
Date: 2012-10-24 07:07:58

Add base address and interrupt line inside Device Tree data for
OMAP5

Signed-off-by: Sebastien Guiriec <redacted>
Reviewed-by: Shubhrajyoti D <redacted>
---
 arch/arm/boot/dts/omap5.dtsi |   19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 737a536..07d2607 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi

@@ -200,6 +200,9 @@
 
 		i2c1: i2c at 48070000 {
 			compatible = "ti,omap4-i2c";
+			reg = <0x48070000 0x100>;
+			interrupts = <0 56 0x4>;
+			interrupt-parent = <&gic>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 			ti,hwmods = "i2c1";

@@ -207,6 +210,9 @@
 
 		i2c2: i2c at 48072000 {
 			compatible = "ti,omap4-i2c";
+			reg = <0x48072000 0x100>;
+			interrupts = <0 57 0x4>;
+			interrupt-parent = <&gic>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 			ti,hwmods = "i2c2";

@@ -214,20 +220,29 @@
 
 		i2c3: i2c at 48060000 {
 			compatible = "ti,omap4-i2c";
+			reg = <0x48060000 0x100>;
+			interrupts = <0 61 0x4>;
+			interrupt-parent = <&gic>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
 
-		i2c4: i2c at 4807A000 {
+		i2c4: i2c at 4807a000 {
 			compatible = "ti,omap4-i2c";
+			reg = <0x4807a000 0x100>;
+			interrupts = <0 62 0x4>;
+			interrupt-parent = <&gic>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 			ti,hwmods = "i2c4";
 		};
 
-		i2c5: i2c at 4807C000 {
+		i2c5: i2c at 4807c000 {
 			compatible = "ti,omap4-i2c";
+			reg = <0x4807c000 0x100>;
+			interrupts = <0 60 0x4>;
+			interrupt-parent = <&gic>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 			ti,hwmods = "i2c5";

-- 
1.7.10.4

[PATCH v3 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

From: Sebastien Guiriec <hidden>
Date: 2012-10-24 07:08:24

Add base address and interrupt line inside Device Tree data for
OMAP5

Signed-off-by: Sebastien Guiriec <redacted>
---
 arch/arm/boot/dts/omap5.dtsi |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 42c78be..737a536 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi

@@ -104,6 +104,9 @@
 
 		gpio1: gpio at 4ae10000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x4ae10000 0x200>;
+			interrupts = <0 29 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio1";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -113,6 +116,9 @@
 
 		gpio2: gpio at 48055000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x48055000 0x200>;
+			interrupts = <0 30 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio2";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -122,6 +128,9 @@
 
 		gpio3: gpio at 48057000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x48057000 0x200>;
+			interrupts = <0 31 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio3";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -131,6 +140,9 @@
 
 		gpio4: gpio at 48059000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x48059000 0x200>;
+			interrupts = <0 32 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio4";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -140,6 +152,9 @@
 
 		gpio5: gpio at 4805b000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x4805b000 0x200>;
+			interrupts = <0 33 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio5";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -149,6 +164,9 @@
 
 		gpio6: gpio at 4805d000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x4805d000 0x200>;
+			interrupts = <0 34 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio6";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -158,6 +176,9 @@
 
 		gpio7: gpio at 48051000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x48051000 0x200>;
+			interrupts = <0 35 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio7";
 			gpio-controller;
 			#gpio-cells = <2>;

@@ -167,6 +188,9 @@
 
 		gpio8: gpio at 48053000 {
 			compatible = "ti,omap4-gpio";
+			reg = <0x48053000 0x200>;
+			interrupts = <0 121 0x4>;
+			interrupt-parent = <&gic>;
 			ti,hwmods = "gpio8";
 			gpio-controller;
 			#gpio-cells = <2>;

-- 
1.7.10.4

Re: [PATCH v3 0/4] ARM: dts: Update OMAP5 with address space and interrupts

From: Benoit Cousson <hidden>
Date: 2012-10-24 09:15:16

Hi Seb,

Sorry, I missed your previous email, your v2 was the right one.
We do have a single INTC in every OMAP, there is no point to repeat the
same data hundred times.
The DTS are already big enough.

On 10/24/2012 09:07 AM, Sebastien Guiriec wrote:

Since kernel 3.7 the DTS data are not overwriten by hwmod data we can add the address space
and interrupt line description inside dtsi file for OMAP5. This serie is updating the
current OMAP5 IP with missing entry.

It has been tested on OMAP5 with 3.7-audio-display feature tree.
- MMC is probing and functional
- TWL6041 probing (GPIO/I2C)
- booting (UART)

Update since v1:
- Add Ack and review
- Fix up commit messages.

Update since v2:
- Add interrupt-parent.

I will take the previous one to avoid the duplication of attributes.

On top of that I will remove the ones introduce in audio IPs for
consistency on OMAP3/4/5 platforms.

Regards,
Benoit

Re: [PATCH v3 0/4] ARM: dts: Update OMAP5 with address space and interrupts

From: Sebastien Guiriec <hidden>
Date: 2012-10-24 09:27:36

Hi Benoit,

On 10/24/2012 11:15 AM, Benoit Cousson wrote:

Hi Seb,

Sorry, I missed your previous email, your v2 was the right one.
We do have a single INTC in every OMAP, there is no point to repeat the
same data hundred times.
The DTS are already big enough.

So in such case we should send a series for audio IP interrupt-parent 
removal for OMAP3/4/5 dtsi file in order to be coherent.

Do you want me to do it?

On 10/24/2012 09:07 AM, Sebastien Guiriec wrote:

quoted

Since kernel 3.7 the DTS data are not overwriten by hwmod data we can add the address space
and interrupt line description inside dtsi file for OMAP5. This serie is updating the
current OMAP5 IP with missing entry.

It has been tested on OMAP5 with 3.7-audio-display feature tree.
- MMC is probing and functional
- TWL6041 probing (GPIO/I2C)
- booting (UART)

Update since v1:
- Add Ack and review
- Fix up commit messages.

Update since v2:
- Add interrupt-parent.

I will take the previous one to avoid the duplication of attributes.

On top of that I will remove the ones introduce in audio IPs for
consistency on OMAP3/4/5 platforms.

Regards,
Benoit

Re: [PATCH v3 0/4] ARM: dts: Update OMAP5 with address space and interrupts

From: Benoit Cousson <hidden>
Date: 2012-10-24 10:09:51

On 10/24/2012 11:27 AM, Sebastien Guiriec wrote:

Hi Benoit,

On 10/24/2012 11:15 AM, Benoit Cousson wrote:

quoted

Hi Seb,

Sorry, I missed your previous email, your v2 was the right one.
We do have a single INTC in every OMAP, there is no point to repeat the
same data hundred times.
The DTS are already big enough.

So in such case we should send a series for audio IP interrupt-parent
removal for OMAP3/4/5 dtsi file in order to be coherent.

Yes. AM33xx was as well using that in some other IPs.

Do you want me to do it?

Thanks, but I've just done the patch, I'll sent it in a couple of minutes.

Benoit

quoted

On 10/24/2012 09:07 AM, Sebastien Guiriec wrote:

quoted

Since kernel 3.7 the DTS data are not overwriten by hwmod data we can
add the address space
and interrupt line description inside dtsi file for OMAP5. This serie
is updating the
current OMAP5 IP with missing entry.

It has been tested on OMAP5 with 3.7-audio-display feature tree.
- MMC is probing and functional
- TWL6041 probing (GPIO/I2C)
- booting (UART)

Update since v1:
- Add Ack and review
- Fix up commit messages.

Update since v2:
- Add interrupt-parent.

I will take the previous one to avoid the duplication of attributes.

On top of that I will remove the ones introduce in audio IPs for
consistency on OMAP3/4/5 platforms.

Regards,
Benoit

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help