[PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode

Hi,

On Tue, Sep 25 2012, Sascha Hauer wrote:

quoted

quoted

quoted

quoted

+- bus-width : Maximum supported bus width. Defaults to 4 if omitted

This is a common mmc property documented in bindings/mmc/mmc.txt.
Instead of duplicating the documentation, we should try to make our
implementation conform to the common definition of the property.

It is conform to the common definition, so all I have to do is drop the
line duplicating the docs. That's easy ;)

Maybe not.  The common binding defines it as a required property while
the patch implements it as an optional one.

So you want to make the code conform to the common spec which has
bus-width as a required property. Is this really worth it to add an
incompatible change to our devicetrees?

We could also break the stalemate by just changing the common spec to
have bus-width become optional, default 4.  It's not going to break the
code of anyone who's been treating it as required.  I don't think there
there was a principled reason behind making it required.

Thanks,

- Chris.
-- 
Chris Ball   [off-list ref]   <http://printf.net/>
One Laptop Per Child

On Tue, Sep 25, 2012 at 03:52:09AM -0400, Chris Ball wrote:

We could also break the stalemate by just changing the common spec to
have bus-width become optional, default 4.  It's not going to break the
code of anyone who's been treating it as required.  I don't think there
there was a principled reason behind making it required.

That would be the best :)

Shawn