[PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on"

Subsystems: the rest

STALE5059d

3 messages, 2 authors, 2012-09-25 · open the first message on its own page

[PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on"

From: festevam@gmail.com (Fabio Estevam)
Date: 2012-09-25 02:52:19

From: Fabio Estevam <redacted>

The initial state of the gpio led can be set directly in "gpios" node.

Hence, linux,default-trigger can be removed.

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index 384d8b6..35489a1 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -94,8 +94,7 @@
 
 		user {
 			label = "green";
-			gpios = <&gpio2 1 0>;
-			linux,default-trigger = "default-on";
+			gpios = <&gpio2 1 1>;
 		};
 	};
 };
-- 
1.7.9.5

[PATCH 2/2] ARM: dts: imx23-olinuxino: Use pinctrl for gpio-led

From: festevam@gmail.com (Fabio Estevam)
Date: 2012-09-25 02:52:20

From: Fabio Estevam <redacted>

Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led driver 
has pinctrl support, so setup the gpio led pin via pinctrl and avoid the 
following warning:

leds-gpio leds.5: pins are not configured from the driver

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx23-olinuxino.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index 35489a1..8bd56fc 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -40,6 +40,15 @@
 					reg = <0>;
 					fsl,pinmux-ids = <
 						0x2013 /* MX23_PAD_SSP1_DETECT__GPIO_2_1 */
+					>;
+					fsl,drive-strength = <0>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <0>;
+				};
+
+				led_pin_gpio0_17: led_gpio0_17 at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
 						0x0113 /* MX23_PAD_GPMI_ALE__GPIO_0_17 */
 					>;
 					fsl,drive-strength = <0>;
@@ -91,6 +100,8 @@
 
 	leds {
 		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&led_pin_gpio0_17>;
 
 		user {
 			label = "green";
-- 
1.7.9.5

[PATCH 1/2] ARM: dts: imx23-olinuxino: Remove unneeded "default-on"

From: Shawn Guo <hidden>
Date: 2012-09-25 07:51:04

On Mon, Sep 24, 2012 at 11:52:19PM -0300, Fabio Estevam wrote:
From: Fabio Estevam <redacted>

The initial state of the gpio led can be set directly in "gpios" node.

Hence, linux,default-trigger can be removed.

Signed-off-by: Fabio Estevam <redacted>
Queued both for 3.8, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help