[PATCH] OMAPDSS: fix return value check in create_dss_pdev()

Subsystems: arm port, omap2+ support, the rest

STALE5047d

2 messages, 2 authors, 2012-10-08 · open the first message on its own page

[PATCH] OMAPDSS: fix return value check in create_dss_pdev()

From: Wei Yongjun <hidden>
Date: 2012-09-21 06:28:23

From: Wei Yongjun <redacted>

In case of error, the function omap_device_alloc() returns ERR_PTR()
not NULL pointer. The NULL test in the return value check should
be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
---
 arch/arm/mach-omap2/display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index af1ed7d..eb1bd01 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -221,7 +221,7 @@ static struct platform_device *create_dss_pdev(const char *pdev_name,
 
 	ohs[0] = oh;
 	od = omap_device_alloc(pdev, ohs, 1, NULL, 0);
-	if (!od) {
+	if (IS_ERR(od)) {
 		pr_err("Could not alloc omap_device for %s\n", pdev_name);
 		r = -ENOMEM;
 		goto err;

[PATCH] OMAPDSS: fix return value check in create_dss_pdev()

From: tony@atomide.com (Tony Lindgren)
Date: 2012-10-08 21:32:12

* Wei Yongjun [off-list ref] [120920 23:29]:
From: Wei Yongjun <redacted>

In case of error, the function omap_device_alloc() returns ERR_PTR()
not NULL pointer. The NULL test in the return value check should
be replaced with IS_ERR().
Thanks applying into omap fixes.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help