[PATCH] pinctrl: clarify idle vs sleep states

Subsystems: pin control subsystem, the rest

STALE5059d

2 messages, 2 authors, 2012-09-26 · open the first message on its own page

[PATCH] pinctrl: clarify idle vs sleep states

From: Linus Walleij <hidden>
Date: 2012-09-26 13:01:42

From: Linus Walleij <redacted>

This pure documentation fix tries to align the "idle" and
"sleep" pin states to the idle and suspend states from
runtime PM.

Signed-off-by: Linus Walleij <redacted>
---
 include/linux/pinctrl/pinctrl-state.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/linux/pinctrl/pinctrl-state.h b/include/linux/pinctrl/pinctrl-state.h
index 634608dc..2dbf71d 100644
--- a/include/linux/pinctrl/pinctrl-state.h
+++ b/include/linux/pinctrl/pinctrl-state.h
@@ -6,13 +6,15 @@
  * @PINCTRL_STATE_DEFAULT: the state the pinctrl handle shall be put
  *	into as default, usually this means the pins are up and ready to
  *	be used by the device driver. This state is commonly used by
- *	hogs to configure muxing and pins at boot.
+ *	hogs to configure muxing and pins at boot, and also as a state
+ *	to go into when returning from sleep and idle in
+ *	.pm_runtime_resume() or ordinary .resume() for example.
  * @PINCTRL_STATE_IDLE: the state the pinctrl handle shall be put into
  *	when the pins are idle. Could typically be set from a
- *	pm_runtime_suspend() operation.
+ *	pm_runtime_idle() operation.
  * @PINCTRL_STATE_SLEEP: the state the pinctrl handle shall be put into
  *	when the pins are sleeping. Could typically be set from a
- *	common suspend() function.
+ *	common pm_runtime_suspend() or ordinary .suspend() function.
  */
 #define PINCTRL_STATE_DEFAULT "default"
 #define PINCTRL_STATE_IDLE "idle"
-- 
1.7.11.3

Re: [PATCH] pinctrl: clarify idle vs sleep states

From: Stephen Warren <hidden>
Date: 2012-09-26 16:57:44

On 09/26/2012 07:01 AM, Linus Walleij wrote:
From: Linus Walleij <redacted>

This pure documentation fix tries to align the "idle" and
"sleep" pin states to the idle and suspend states from
runtime PM.
Seems reasonable,
Acked-by: Stephen Warren <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help