[PATCH] ARM: fix warning on uninitialized offset.un
From: Cyril Chemparathy <hidden>
Date: 2012-09-12 15:46:17
Also in:
lkml
Subsystem:
arm port, the rest · Maintainers:
Russell King, Linus Torvalds
This patch fixes the following warning: arch/arm/mm/alignment.c: In function 'do_alignment': arch/arm/mm/alignment.c:327:15: warning: 'offset.un' may be used uninitialized in this function [-Wmaybe-uninitialized] arch/arm/mm/alignment.c:749:21: note: 'offset.un' was declared here The fix is to promote the initialization of offset into do_alignment(). Signed-off-by: Cyril Chemparathy <redacted> --- arch/arm/mm/alignment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
index 9107231..d15877c 100644
--- a/arch/arm/mm/alignment.c
+++ b/arch/arm/mm/alignment.c@@ -699,7 +699,6 @@ do_alignment_t32_to_handler(unsigned long *pinstr, struct pt_regs *regs, unsigned long instr = *pinstr; u16 tinst1 = (instr >> 16) & 0xffff; u16 tinst2 = instr & 0xffff; - poffset->un = 0; switch (tinst1 & 0xffe0) { /* A6.3.5 Load/Store multiple */
@@ -795,6 +794,7 @@ do_alignment(unsigned long addr, unsigned int fsr, struct pt_regs *regs) fixup: regs->ARM_pc += isize; + offset.un = 0; switch (CODING_BITS(instr)) { case 0x00000000: /* 3.13.4 load/store instruction extensions */
--
1.7.9.5