[PATCH] ARM: ux500: set proper GIC flags

Subsystems: arm port, arm/nomadik/ux500 architectures, the rest

STALE5093d

3 messages, 3 authors, 2012-08-24 · open the first message on its own page

[PATCH] ARM: ux500: set proper GIC flags

From: Linus Walleij <hidden>
Date: 2012-08-24 13:01:04

From: Linus Walleij <redacted>

The Ux500 will be able to wake up on any IRQ, so flag it with
IRQCHIP_SKIP_SET_WAKE, and we want to mask off the IRQs when
going to suspend to avoid transient effects so also flag
this with IRQCHIP_MASK_ON_SUSPEND.

Cc: Etienne Carriere <redacted>
Signed-off-by: Linus Walleij <redacted>
---
 arch/arm/mach-ux500/cpu.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index e2360e7..2957432 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -51,6 +51,8 @@ void __init ux500_init_irq(void)
 	void __iomem *dist_base;
 	void __iomem *cpu_base;
 
+	gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
+
 	if (cpu_is_u8500_family()) {
 		dist_base = __io_address(U8500_GIC_DIST_BASE);
 		cpu_base = __io_address(U8500_GIC_CPU_BASE);
-- 
1.7.11.3

[PATCH] ARM: ux500: set proper GIC flags

From: Shilimkar, Santosh <hidden>
Date: 2012-08-24 13:08:39

On Fri, Aug 24, 2012 at 6:31 PM, Linus Walleij
[off-list ref] wrote:
quoted hunk
From: Linus Walleij <redacted>

The Ux500 will be able to wake up on any IRQ, so flag it with
IRQCHIP_SKIP_SET_WAKE, and we want to mask off the IRQs when
going to suspend to avoid transient effects so also flag
this with IRQCHIP_MASK_ON_SUSPEND.

Cc: Etienne Carriere <redacted>
Signed-off-by: Linus Walleij <redacted>
---
 arch/arm/mach-ux500/cpu.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index e2360e7..2957432 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -51,6 +51,8 @@ void __init ux500_init_irq(void)
        void __iomem *dist_base;
        void __iomem *cpu_base;

+       gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
+
With this patch, you should no longer need the dummy set_irq_wake()
patch which I was form
you for ux500.

Regards
Santosh

[PATCH] ARM: ux500: set proper GIC flags

From: Linus Walleij <hidden>
Date: 2012-08-24 20:28:40

On Fri, Aug 24, 2012 at 3:08 PM, Shilimkar, Santosh
[off-list ref] wrote:
quoted
+       gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
+
With this patch, you should no longer need the dummy set_irq_wake()
patch which I was form
you for ux500.
Yep, it's somehow gone already (though it was preserved on the
internal kernel...)

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help