[PATCH] atmel-ssc: include linux/io.h for raw io

Subsystems: atm, microchip ssc driver, the rest

STALE5074d

12 messages, 5 authors, 2012-09-11 · open the first message on its own page

[PATCH] atmel-ssc: include linux/io.h for raw io

From: Joachim Eastwood <hidden>
Date: 2012-08-13 19:59:10

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by: Joachim Eastwood <redacted>
---
 include/linux/atmel-ssc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
index 0602339..4eb3175 100644
--- a/include/linux/atmel-ssc.h
+++ b/include/linux/atmel-ssc.h

@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;

-- 
1.7.11

[PATCH] atmel-ssc: include linux/io.h for raw io

From: Nicolas Ferre <hidden>
Date: 2012-08-23 12:44:38

On 08/13/2012 09:59 PM, Joachim Eastwood :

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by: Joachim Eastwood <redacted>

Added to at91-fixes for 3.6. Thanks!

Arnd, can I queue this one in my upcoming pull-request to you?

quoted hunk

---
 include/linux/atmel-ssc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
index 0602339..4eb3175 100644
--- a/include/linux/atmel-ssc.h
+++ b/include/linux/atmel-ssc.h

@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;


-- 
Nicolas Ferre

[PATCH] atmel-ssc: include linux/io.h for raw io

From: Nicolas Ferre <hidden>
Date: 2012-08-23 12:51:25

On 08/13/2012 09:59 PM, Joachim Eastwood :

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by: Joachim Eastwood <redacted>

Liam, Mark,

May I have your Acked-by for this patch, I plan to queue it with my
other at91-related fixes in arm-soc tree?

Thanks, best regards,

quoted hunk

---
 include/linux/atmel-ssc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
index 0602339..4eb3175 100644
--- a/include/linux/atmel-ssc.h
+++ b/include/linux/atmel-ssc.h

@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;


-- 
Nicolas Ferre

[PATCH] atmel-ssc: include linux/io.h for raw io

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-08-23 13:31:38

On Thursday 23 August 2012, Nicolas Ferre wrote:

On 08/13/2012 09:59 PM, Joachim Eastwood :

quoted

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by: Joachim Eastwood <redacted>

Added to at91-fixes for 3.6. Thanks!

Arnd, can I queue this one in my upcoming pull-request to you?

Sure, no problem.

	Arnd

[PATCH] atmel-ssc: include linux/io.h for raw io

From: Mark Brown <hidden>
Date: 2012-08-23 15:23:24

On Thu, Aug 23, 2012 at 02:51:25PM +0200, Nicolas Ferre wrote:

May I have your Acked-by for this patch, I plan to queue it with my
other at91-related fixes in arm-soc tree?

Don't think the original patch was CCed to me - can you send me a copy
please and I'll take a look?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120823/c63b9cf6/attachment.sig>

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Nicolas Ferre <hidden>
Date: 2012-08-23 16:14:54

From: Joachim Eastwood <redacted>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by: Joachim Eastwood <redacted>
Signed-off-by: Nicolas Ferre <redacted>
---
Mark,

Here is a copy of the original patch by Joachim. Can you please take a look and
give your acknowledgement so that I can queue it in arm-soc tree.

Thanks, bye,

 include/linux/atmel-ssc.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
index 0602339..4eb3175 100644
--- a/include/linux/atmel-ssc.h
+++ b/include/linux/atmel-ssc.h

@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;

-- 
1.7.10

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2012-08-23 16:46:22

On 18:14 Thu 23 Aug     , Nicolas Ferre wrote:

From: Joachim Eastwood <redacted>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by: Joachim Eastwood <redacted>
Signed-off-by: Nicolas Ferre <redacted>

Acked-by: Jean-Christophe PLAGNIOL-VILLARD <redacted>

Best Regards,
J.

quoted hunk

---
Mark,

Here is a copy of the original patch by Joachim. Can you please take a look and
give your acknowledgement so that I can queue it in arm-soc tree.

Thanks, bye,

 include/linux/atmel-ssc.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h
index 0602339..4eb3175 100644
--- a/include/linux/atmel-ssc.h
+++ b/include/linux/atmel-ssc.h

@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;

-- 
1.7.10


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Mark Brown <hidden>
Date: 2012-08-25 20:25:16

On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote:

From: Joachim Eastwood <redacted>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Acked-by: Mark Brown <redacted>

but why not just apply it to the ASoC tree?

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Nicolas Ferre <hidden>
Date: 2012-08-27 08:01:21

On 08/25/2012 10:25 PM, Mark Brown :

On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote:

quoted

From: Joachim Eastwood <redacted>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Acked-by: Mark Brown <redacted>

but why not just apply it to the ASoC tree?

Fine by me then: so Mark, can you take it for a 3.6 fixes branch?

(I remove it from my at91-fixes branch that will go through arm-soc tree).

Best regards,
-- 
Nicolas Ferre

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Mark Brown <hidden>
Date: 2012-08-27 16:23:46

On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote:

From: Joachim Eastwood <redacted>

Include linux/io.h for raw io operations in atmel-scc header.

Applied, thanks.

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Nicolas Ferre <hidden>
Date: 2012-09-11 12:15:18

On 08/27/2012 10:01 AM, Nicolas Ferre :

On 08/25/2012 10:25 PM, Mark Brown :

quoted

On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote:

quoted

From: Joachim Eastwood <redacted>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
  CC [M]  sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl'
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Acked-by: Mark Brown <redacted>

but why not just apply it to the ASoC tree?

Fine by me then: so Mark, can you take it for a 3.6 fixes branch?

(I remove it from my at91-fixes branch that will go through arm-soc tree).

Hi Mark,

Ping?

Best regards,
-- 
Nicolas Ferre

[PATCH] ASoC: atmel-ssc: include linux/io.h for raw io

From: Mark Brown <hidden>
Date: 2012-09-11 12:38:02

On Tue, Sep 11, 2012 at 02:15:18PM +0200, Nicolas Ferre wrote:

Ping?

Pong.  Don't send contentless pings...  If you want me to apply the
patch someone should send me a copy.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help