# \[PATCH 2/4\] Input: keypad: Add smsc ece1099 keypad driver

- From: Felipe Balbi \<hidden\>
- Date: 2012-08-21 10:50:51 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2012/08/3911926
- Thread: https://ratatoskr.run/linux-arm-kernel/2012/08/3911919/t.md

```text
Hi,

On Tue, Aug 21, 2012 at 04:15:38PM +0530, Sourav Poddar wrote:
> +static struct platform_driver smsc_driver = {
> +	.driver = {
> +		.name	= "smsc-keypad",
> +		.of_match_table = of_match_ptr(smsc_keypad_dt_match),
> +		.owner  = THIS_MODULE,
> +	},
> +	.probe		= smsc_probe,
> +	.remove		= smsc_remove,

one extra comment which I forgot. You probably should put your remove on
__devexit and add __devexit_p(smsc_remove) here.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120821/f3284b73/attachment.sig>
```