Javier Martinez Canillas [off-list ref] writes:
commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
Author: Russell King [off-list ref]
Date: Sat Apr 21 22:41:10 2012 +0100
mmc: omap: remove private DMA API implementation
removed the private DMA API implementation from the OMAP mmc host to
make it use exclusively the DMA engine API.
Unfortunately the omap2plus_defconfig doesn't enable this feature
leading to the following error on an IGEPv2 Rev.C (and probably on most
boards with MMC support):
Personally, I'd rather see this fixed by having the drivers that depend
on DMA engine 'select DMADEVICES'. That way, any defconfig will work
correctly instead of just omap2plus_defconfig.
Kevin
quoted hunk
[ 2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
[ 2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
---
arch/arm/configs/omap2plus_defconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index b152de7..e58edc3 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_TWL92330=y
CONFIG_RTC_DRV_TWL4030=y
+CONFIG_DMADEVICES=y
+CONFIG_DMA_OMAP=y
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y
# CONFIG_EXT3_FS_XATTR is not set
On Mon, Jul 16, 2012 at 7:12 PM, Kevin Hilman [off-list ref] wrote:
Javier Martinez Canillas [off-list ref] writes:
quoted
commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
Author: Russell King [off-list ref]
Date: Sat Apr 21 22:41:10 2012 +0100
mmc: omap: remove private DMA API implementation
removed the private DMA API implementation from the OMAP mmc host to
make it use exclusively the DMA engine API.
Unfortunately the omap2plus_defconfig doesn't enable this feature
leading to the following error on an IGEPv2 Rev.C (and probably on most
boards with MMC support):
Personally, I'd rather see this fixed by having the drivers that depend
on DMA engine 'select DMADEVICES'. That way, any defconfig will work
correctly instead of just omap2plus_defconfig.
Kevin
Hi Kevin,
Thanks a lot for your feedback. I'll do what you suggest and send a v2
of the patch.
Best regards,
Javier
* Javier Martinez Canillas [off-list ref] [120716 16:33]:
On Mon, Jul 16, 2012 at 7:12 PM, Kevin Hilman [off-list ref] wrote:
quoted
Javier Martinez Canillas [off-list ref] writes:
quoted
commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
Author: Russell King [off-list ref]
Date: Sat Apr 21 22:41:10 2012 +0100
mmc: omap: remove private DMA API implementation
removed the private DMA API implementation from the OMAP mmc host to
make it use exclusively the DMA engine API.
Unfortunately the omap2plus_defconfig doesn't enable this feature
leading to the following error on an IGEPv2 Rev.C (and probably on most
boards with MMC support):
Personally, I'd rather see this fixed by having the drivers that depend
on DMA engine 'select DMADEVICES'. That way, any defconfig will work
correctly instead of just omap2plus_defconfig.
Kevin
Hi Kevin,
Thanks a lot for your feedback. I'll do what you suggest and send a v2
of the patch.
I'd rather see the drivers fixed to work with and without DMA as the
channels can run out. Also forcing the select is not good for distro kernels.
I'll apply this fix into l-o master branch while we're discussing the
issue.
Regards,
Tony